GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable building universal (x64,arm64) binaries for MacOS by SteveL-MSFT · Pull Request #64 · PowerShell/PowerShell-Native

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Feb 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Created cmakefile specifying both x64 and arm64 architectures. Tested locally on M1 MacBookPro using file to verify the resulting dylib is universal.

PS> file /Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64]
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
/Users/steve/repos/PowerShell-Native/src/powershell-unix/libpsl-native.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64

Needed to switch to vmimage for MacOS 10.15+ which has XCode12 to support building universal binary for M1 and x64.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andyleejordan reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@SteveL-MSFT
enable building universal (x64,arm64) binaries for MacOS
088df10
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) February 28, 2021 18:58
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Feb 28, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Feb 28, 2021
Enable building PowerShell for Apple M1 runtime PowerShell/PowerShell#14923
Merged
8 of 22 tasks
Steve Lee (SteveL-MSFT) added 3 commits February 28, 2021 15:19
@SteveL-MSFT
set minimum osx version
f29d38f
@SteveL-MSFT
specify latest macos
a9161b2
@SteveL-MSFT
change to vmimage pool
9fef518
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Mar 1, 2021
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .vsts-ci/mac.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 2, 2021
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title enable building universal (x64,arm64) binaries for MacOS Enable building universal (x64,arm64) binaries for MacOS Mar 8, 2021
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 8, 2021 •
edited by TravisEz13
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) - can you verify that the release build succeeds?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
change release build to use macOS-latest vmimage which has xcode12
5e3c014
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Mar 9, 2021

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) verified release build succeeds and library is universal
adityapatwardhan and andyleejordan reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 2ad0b58 into PowerShell:master Mar 9, 2021
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the build-m1 branch March 10, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SteveL-MSFT @adityapatwardhan @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.