GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Enable building PowerShell for Apple M1 runtime by SteveL-MSFT · Pull Request #14923 · PowerShell/PowerShell Conversation
|
|
So does this build a universal binary or just one compiled for arm64? Does it require any work from .NET, I remember reading something about M1 support in the new preview so assumed PowerShell had to wait for that. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Jordan Borean (@jborean93) This PR leverages dotnet to build M1 optimized binaries. It depends on PowerShell/PowerShell-Native#64 which builds universal native binaries for pwsh. For "universal binaries" we could just have a MSIL non-crossgen'd package, but startup speed is greatly affected. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Awesome thanks for the info, will have to get a move on updating the mi fork to produce arm64 libraries so powershell can use them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Is this 'tools' path filter just for macOS, or for all runtimes? I assume the latter, but it is not clear to me. Maybe add a comment to reassure.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The tools folder is for all runtimes, but for some reason, x64-arm64 for macOS has a crossgen in that additional runtime folder which is discovered, but doesn't actually work. The one in tools does work.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Would you submit another PR to update the release build or add that to this PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Travis Plunk (@TravisEz13) I can update this PR to also do the build, was using this to test locally |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
dea89eb to
7f83eaa
Compare
|
Travis Plunk (@TravisEz13) I spent some time looking at the yml and psm1 that does the build, but it's much more complicated now than the last time I made changes. I would suggest having it integrated with the build as a separate PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) is this ready to merge? Don't we need the updated native nuget? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The description says it is dependent on the PR in PS-Native repo. The NuGet package after merging that that PR has to be released too. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
For the full package to work, it requires the universal binary from powershell-native, however, this PR itself can be merged. Andrew (@anmenaga) can you do a separate PR to enable building of the M1 pkg? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.