GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove macros for unordered maps/sets by Enchufa2 · Pull Request #1372 · RcppCore/Rcpp

Conversation

@Enchufa2

@Enchufa2 Enchufa2 commented Mar 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Pretty simple one. Will rebase and mark as ready for review when #1371 is merged.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eddelbuettel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Enchufa2 added 3 commits March 26, 2025 20:25
@Enchufa2
remove macros for unordered maps/sets
2f78e46
@Enchufa2
do not deprecate yet
47db39e
@Enchufa2
update Changelog
dca5edb
@Enchufa2
Enchufa2 force-pushed the feature/unordered branch from 020c2cd to dca5edb Compare March 26, 2025 19:27
@Enchufa2
Enchufa2 marked this pull request as ready for review March 26, 2025 19:27
@Enchufa2
Enchufa2 requested review from eddelbuettel and kevinushey March 26, 2025 19:27
@Enchufa2

Enchufa2 commented Mar 26, 2025

Copy link
Copy Markdown
Member Author

Rebased.
eddelbuettel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eddelbuettel
Roll micro version and date
71b01bb 
Used by #1372
@eddelbuettel

eddelbuettel commented Mar 26, 2025

Copy link
Copy Markdown
Member

Rev dep now running with tag 1.0.14.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eddelbuettel
eddelbuettel approved these changes Mar 26, 2025
View reviewed changes

@eddelbuettel eddelbuettel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, should not do damage but let's wait just in case.

(And let's keep in mind that I also skip a few of the more expensive ones...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eddelbuettel

eddelbuettel commented Mar 26, 2025

Copy link
Copy Markdown
Member

BTW I think you accidentally mistyped the buttons in the checklist. Hit number two but skip number three?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Enchufa2

Enchufa2 commented Mar 26, 2025

Copy link
Copy Markdown
Member Author

I did! Fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kevinushey
kevinushey approved these changes Mar 27, 2025
View reviewed changes

@kevinushey kevinushey left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 28, 2025
@eddelbuettel
Rcpp 1.0.14.11 with PR 1372
1dcec5e 
RcppCore/Rcpp#1372
@eddelbuettel

eddelbuettel commented Mar 28, 2025

Copy link
Copy Markdown
Member

As anticipated, this too passed without event or issues, more here, so merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eddelbuettel
eddelbuettel merged commit 30df687 into master Mar 28, 2025
@eddelbuettel
eddelbuettel deleted the feature/unordered branch March 28, 2025 23:07
@eddelbuettel eddelbuettel mentioned this pull request Mar 28, 2025
C++11 as minimum supported standard #1365
Closed
9 of 14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes
@kevinushey kevinushey kevinushey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Enchufa2 @eddelbuettel @kevinushey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.