GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable lambdas in all sugar functions by Enchufa2 · Pull Request #1373 · RcppCore/Rcpp

Conversation

@Enchufa2

@Enchufa2 Enchufa2 commented Mar 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #1365, as discussed in #1370. Takes the idea in #296 that enabled lambdas for sapply, and generalizes it as a variadic result_of that now is applied to lapply, mapply and outer too, enabling lambdas for them too.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Enchufa2 added 4 commits March 29, 2025 01:04
@Enchufa2
generalize sapply solution to get result_of functions
51725a4
@Enchufa2
adapt outer, lapply, mapply
e37236c
@Enchufa2
add tests
619d404
@Enchufa2
update Changelog
619432f
@Enchufa2
Enchufa2 requested review from eddelbuettel and kevinushey March 29, 2025 00:23
@Enchufa2 Enchufa2 mentioned this pull request Mar 29, 2025
C++11 as minimum supported standard #1365
Closed
9 of 14 tasks
kevinushey
kevinushey approved these changes Mar 29, 2025
View reviewed changes

@kevinushey kevinushey left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eddelbuettel

eddelbuettel commented Mar 31, 2025

Copy link
Copy Markdown
Member

As discussed over DM as it happened, the reverse depends run for this one tossed up three packages coughing so to be refined or to be patched there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Enchufa2
re-add support for functions without argument specification
8ba2d7b
@Enchufa2

Enchufa2 commented Mar 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I think that 8ba2d7b fixes the issue (some, but not all). I dropped that before just because it was giving me problems, and collided somehow with the other specialization. But it works now, so my previous issues were probably due to some intermediate state of the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Enchufa2
fix missing typedef
2d7c521
@Enchufa2

Enchufa2 commented Mar 31, 2025

Copy link
Copy Markdown
Member Author

Stupid mistake... I inadvertently dropped typedef at some point. Now expertsurv, flexsurv and texmex should compile just fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eddelbuettel

eddelbuettel commented Mar 31, 2025

Copy link
Copy Markdown
Member

Very nice, and confirmed for those three plus one that was flakey in the last run (and now passed too). Waiting on one new package....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 31, 2025
@eddelbuettel
First incremental run for PR 1373
1e4fbb9 
See RcppCore/Rcpp#1373
@eddelbuettel
Roll micro version and date
7c5df0c
eddelbuettel
eddelbuettel approved these changes Mar 31, 2025
View reviewed changes

@eddelbuettel eddelbuettel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Enchufa2 reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@Enchufa2
Enchufa2 merged commit a1737c1 into master Mar 31, 2025
@Enchufa2
Enchufa2 deleted the feature/result_of_function branch March 31, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes
@kevinushey kevinushey kevinushey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Enchufa2 @eddelbuettel @kevinushey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.