GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BUG: fix export ellipses to kml function by Gui-FernandesBR · Pull Request #712 · RocketPy-Team/RocketPy

Conversation

@Gui-FernandesBR

@Gui-FernandesBR Gui-FernandesBR commented Oct 12, 2024

Copy link
Copy Markdown
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

  • Yes
  • No

Additional information

Enter text here...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Gui-FernandesBR
BUG: fix export ellipses to kml function
5208984
@Gui-FernandesBR
Gui-FernandesBR requested a review from a team as a code owner October 12, 2024 02:45
@github-actions github-actions Bot assigned Gui-FernandesBR Oct 12, 2024
@Gui-FernandesBR Gui-FernandesBR linked an issue Oct 12, 2024 that may be closed by this pull request
BUG: Fix the export ellipses to kml feature #658
Closed
@codecov

codecov Bot commented Oct 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.75862% with 15 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (13e66f6) to head (6d7a537).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/plots/monte_carlo_plots.py 52.63% 9 Missing ⚠️
rocketpy/simulation/monte_carlo.py 81.81% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #712      +/-   ##
===========================================
+ Coverage    75.88%   75.95%   +0.06%     
===========================================
  Files           99       99              
  Lines        11222    11237      +15     
===========================================
+ Hits          8516     8535      +19     
+ Misses        2706     2702       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Gui-FernandesBR
BUG: fix export ellipses to kml function
9cde460
@Gui-FernandesBR
Gui-FernandesBR force-pushed the bug/kml-ellipses branch from 5208984 to 9cde460 Compare October 30, 2024 06:17
Lucas-Prates
Lucas-Prates reviewed Nov 1, 2024
View reviewed changes
Comment thread rocketpy/plots/monte_carlo_plots.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Gui-FernandesBR added 4 commits November 1, 2024 19:09
@Gui-FernandesBR
Merge branch 'bug/kml-ellipses' of https://github.com/RocketPy-Team/R…
05cb03e 
…ocketPy into bug/kml-ellipses
@Gui-FernandesBR
MNT: raise error if no apogee or impact data is found for plotting el…
dbaba70 
…lipses
@Gui-FernandesBR
DEV: Adds #712 to changelog
ccd0f4e
@Gui-FernandesBR
TST: increase monte carlo tests
6d7a537
@Gui-FernandesBR
Gui-FernandesBR merged commit 282e54e into develop Nov 2, 2024
@Gui-FernandesBR
Gui-FernandesBR deleted the bug/kml-ellipses branch November 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lucas-Prates Lucas-Prates Lucas-Prates left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Gui-FernandesBR Gui-FernandesBR

Labels

None yet

Projects

No open projects
LibDev Roadmap
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Fix the export ellipses to kml feature

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Gui-FernandesBR @Lucas-Prates
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.