GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update importlib/test_importlib from CPython 3.10.6 by youknowone · Pull Request #3919 · RustPython/RustPython

Conversation

youknowone commented Jul 18, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

~~I have no idea whats going on its failure.~~

blocked by ~~#3863~~, #3961

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fanninpm commented Jul 18, 2022

Copy link

Copy Markdown

Contributor

Directory tree in RustPython (as it stands right now):

Lib/importlib/
├── __init__.py
├── _bootstrap.py
├── _bootstrap_external.py
├── abc.py
├── machinery.py
├── metadata.py
├── resources.py
└── util.py

Directory tree in CPython 3.10:

Lib/importlib/
├── metadata/
│   ├── __init__.py
│   ├── _adapters.py
│   ├── _collections.py
│   ├── _functools.py
│   ├── _itertools.py
│   ├── _meta.py
│   └── _text.py
├── __init__.py
├── _abc.py
├── _adapters.py
├── _bootstrap.py
├── _bootstrap_external.py
├── _common.py
├── abc.py
├── machinery.py
├── readers.py
├── resources.py
└── util.py

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone force-pushed the importlib branch from 3c7c13b to 8aaf728 Compare

July 18, 2022 14:48

youknowone commented Jul 18, 2022

Copy link

Copy Markdown

Member Author

I am sorry, it was my mistake to miss new files in commit. The error is very unexpected:

Traceback (most recent call last):
  File "/Users/user/Projects/RustPython/vm/pylib-crate/Lib/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/Users/user/Projects/RustPython/vm/pylib-crate/Lib/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "_frozen_importlib", line 1129, in __import__
  File "_frozen_importlib", line 1050, in _gcd_import
  File "_frozen_importlib", line 1027, in _find_and_load
  File "_frozen_importlib", line 1027, in _find_and_load
  File "_frozen_importlib", line 1006, in _find_and_load_unlocked
  File "_frozen_importlib", line 703, in _load_unlocked
  File "_frozen_importlib", line 701, in _load_unlocked
  File "_frozen_importlib", line 694, in _load_unlocked
  File "_frozen_importlib", line 688, in _load_unlocked
  File "_frozen_importlib_external", line 879, in exec_module
  File "_frozen_importlib_external", line 1017, in get_code
  File "_frozen_importlib_external", line 948, in source_to_code
  File "_frozen_importlib", line 241, in _call_with_frames_removed
  File "/Users/user/Projects/RustPython/vm/pylib-crate/Lib/test/test_importlib/test_util.py", line 1
    from . import util
     ^
SyntaxError: Got unexpected token  at line 1 column 2
from . import util
 ^

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone commented Jul 18, 2022

Copy link

Copy Markdown

Member Author

Thank you, that explains the diff. It means we don't support bom for files.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone commented Jul 18, 2022

Copy link

Copy Markdown

Member Author

plistlib depends on new importlib

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone force-pushed the importlib branch from 8aaf728 to bdafd29 Compare

July 18, 2022 15:10

fanninpm reviewed

Jul 18, 2022

View reviewed changes

Comment thread

Lib/test/test_importlib/test_util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

fanninpm commented Jul 18, 2022

Copy link

Copy Markdown

Contributor

CPython has known about this issue for quite some time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone force-pushed the importlib branch from bdafd29 to 6349673 Compare

July 24, 2022 19:07

fanninpm mentioned this pull request

Jul 24, 2022

Handle windows test proper way #3960

Closed

6 of 11 tasks

youknowone force-pushed the importlib branch from 0157d89 to 5161c9a Compare

August 5, 2022 21:19

youknowone force-pushed the importlib branch 2 times, most recently from 638c8ab to 3a16e84 Compare

August 13, 2022 18:35

youknowone marked this pull request as ready for review

August 13, 2022 18:35

youknowone mentioned this pull request

Aug 13, 2022

Support setuptools #4055

Closed

1 of 2 tasks

youknowone changed the title ~~update importlib/test_importlib~~ Update importlib/test_importlib from CPython 3.10.6

Aug 13, 2022

moreal mentioned this pull request

Aug 13, 2022

Update importlib from CPython 3.10.6 #4040

Closed

youknowone force-pushed the importlib branch 2 times, most recently from a24fd70 to c79d9df Compare

August 13, 2022 21:53

youknowone commented

Aug 13, 2022

View reviewed changes

Comment thread

Lib/test/test_importlib/test_locks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_importlib/test_metadata_api.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_importlib/util.py

		tests that require it to be set to False."""
		if sys.dont_write_bytecode:
		return lambda args, *kwargs: None
		return unittest.skip(fxn)

youknowone Aug 13, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is submitted to python/cpython#95972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone force-pushed the importlib branch 8 times, most recently from 68fd66d to 726d5af Compare

August 16, 2022 18:11

CPython developers and others added 2 commits

August 18, 2022 03:22


          Update zipimport from CPython 3.10.5

97e6542


          Remove markers from succesful zipimport tests

03ae069

CPython Developers and others added 3 commits

August 18, 2022 03:22


          Update importlib/test_importlib from CPython 3.10.6

da10933


          @writes_bytecode_files to skip

47dbafe

python/cpython#95972


          mark hanging/failing tests

9a40c87

youknowone force-pushed the importlib branch from aa63c65 to 9a40c87 Compare

August 17, 2022 18:22

youknowone merged commit 99b34a9 into RustPython:main

Aug 17, 2022

youknowone deleted the importlib branch

August 17, 2022 19:52

fanninpm mentioned this pull request

Dec 24, 2022

Handling of BOM (byte order mark) in source files #4353

Closed

Reviewers

fanninpm

fanninpm left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

youknowone commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanninpm commented Jul 18, 2022

Uh oh!

youknowone commented Jul 18, 2022

Uh oh!

youknowone commented Jul 18, 2022

Uh oh!

youknowone commented Jul 18, 2022

Uh oh!

Uh oh!

fanninpm commented Jul 18, 2022

Uh oh!

Uh oh!

Uh oh!

youknowone Aug 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

youknowone commented Jul 18, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.