GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95971: Turn @writes_bytecode_files to skip when not running by youknowone · Pull Request #95972 · python/cpython

Conversation

@youknowone

@youknowone youknowone commented Aug 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: test_importlib.util.writes_bytecode_files decorator make false success instead of skipped when -B given #95971

Before:

$ ./python.exe -B -m test test_importlib -v

(skipped)

----------------------------------------------------------------------
Ran 1411 tests in 1.979s

OK (skipped=20, expected failures=1)

After:

$ ./python.exe -B -m test test_importlib -v

(skipped)

----------------------------------------------------------------------
Ran 1411 tests in 2.103s

OK (skipped=91, expected failures=1)

Please check the skipped number is changed while actual test set is not changed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
pythongh-95971: Turn @writes_bytecode_files to skip when not running
ded5dbb
@bedevere-bot bedevere-bot added the awaiting review label Aug 13, 2022
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 13, 2022
@youknowone
@writes_bytecode_files to skip
ed9d8e4 
python/cpython#95972
@youknowone youknowone mentioned this pull request Aug 13, 2022
Update importlib/test_importlib from CPython 3.10.6 RustPython/RustPython#3919
Merged
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 13, 2022
@youknowone
@writes_bytecode_files to skip
ee6c62d 
python/cpython#95972
@corona10 corona10 added the skip news label Aug 14, 2022
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 14, 2022
@youknowone
@writes_bytecode_files to skip
a19990c 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 14, 2022
@youknowone
@writes_bytecode_files to skip
76f02f6 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
cd54817 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
406616b 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
b5713f0 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
1ac9232 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
aebc978 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
a6d53f9 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 17, 2022
@youknowone
@writes_bytecode_files to skip
47dbafe 
python/cpython#95972
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 7, 2022
JelleZijlstra
JelleZijlstra reviewed Oct 7, 2022
View reviewed changes
Comment thread Lib/test/test_importlib/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
JelleZijlstra added 2 commits October 11, 2022 19:39
@JelleZijlstra
Update Lib/test/test_importlib/util.py
dd1a1a0
@JelleZijlstra
Merge branch 'main' into fix-writes-bytecode-files
c4905e1
@JelleZijlstra
JelleZijlstra merged commit 07b5c46 into python:main Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @youknowone for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Oct 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@youknowone @miss-islington
pythongh-95971: Turn @writes_bytecode_files to skip when not running (p…
0b292a3 
…ythonGH-95972)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 15, 2022

Copy link
Copy Markdown

GH-98279 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
@bedevere-bot

bedevere-bot commented Oct 15, 2022

Copy link
Copy Markdown

GH-98280 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@youknowone @miss-islington
pythongh-95971: Turn @writes_bytecode_files to skip when not running (p…
c0e8679 
…ythonGH-95972)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <[email protected]>
@youknowone
youknowone deleted the fix-writes-bytecode-files branch October 15, 2022 14:58
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @youknowone
gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972
4e78d94 
)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <[email protected]>
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @youknowone
gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972
146232f 
)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@youknowone @miss-islington @bedevere-bot @JelleZijlstra @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.