GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Replace Python parser with ruff parser by etaloof · Pull Request #5494 · RustPython/RustPython

Conversation

etaloof commented Jan 28, 2025

Copy link

Copy Markdown

Contributor

This PR replaces the Python parser with the ruff Parser. I had to create a new PR because I messed up #5453.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

qingshi163 and others added 30 commits

September 10, 2024 19:09


          stage1

93b7d6b


          compiler pass build

e0a3f26


          introduce rustpython-compiler-source

38575bd


          stage2

dce0d94


          fixup

3162b9b


          pass compile

1f7024a


          Fix hello world compiler test

e189ecf


          Fix code generation for if-elif-else statement

0f100e9


          Fix code generation for lambda expression

b42f88f


          Fix code generation for integers

7c53857


          Fix code generation for fstrings

424e05a


          Fix code generation for if statement

2691cbe


          Fix code generation for if statement

a98a623


          Fix code generation for if statement

168aa01


          Fix code generation for fstring

c25d958


          Fix code generation for class definition

4e29dd4


          Replace feature flags

89afad2


          Initialize frozen core modules

e760ac7


          Allow __future__ import after module doc comment

2987cbe


          Disable ast module

c10df16


          Commit remaining fixes for compile errors in examples

bcfbf88


          Fix some warnings

def0e42


          Update ast stdlib module

4bef13b


          Update ast stdlib module

1fd48c7


          Update ast stdlib module

ca2b302


          Update ast stdlib module

e9bc377


          Update ast stdlib module

c6ece03


          Split ast stdlib module into files

5c22c39


          Fix codegen for positional arguments with defaults

6b49cfb


          Update ast stdlib module

4cdd4ae


          Fix todos by implementing missing ast conversions and deleting unused…

16ac422

… code

etaloof force-pushed the ruff-parser branch from f45b660 to 16ac422 Compare

March 15, 2025 17:16

coolreader18 force-pushed the ruff-parser branch from a916367 to 798fdc0 Compare

March 19, 2025 18:44


          Merge branch 'main' into ruff-parser

77d49d2

coolreader18 force-pushed the ruff-parser branch from 798fdc0 to 77d49d2 Compare

March 19, 2025 18:46

coolreader18 added 3 commits

March 19, 2025 14:54


          Merge branch 'main' into ruff-parser

7c888d9


          Appease clippy

b90d02e


          Fix remaining ast tests

e328031

coolreader18 force-pushed the ruff-parser branch from de413f9 to e328031 Compare

March 19, 2025 21:37

coolreader18 added 3 commits

March 19, 2025 17:49


          Fix remaining ast tests

23cc9b8


          Mark/fix remaining tests

226b677


          Fix more

c15da44

coolreader18 force-pushed the ruff-parser branch from b4f7e69 to c15da44 Compare

March 20, 2025 01:11


          Hacky windows fix

85e40b3

coolreader18 approved these changes

Mar 20, 2025

View reviewed changes

coolreader18 commented Mar 20, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Ok, CI is green! I'm going to merge this now, just since it's such a huge changeset, and it's kinda unwieldy to deal with. If there are changes that need to be made, they can be as follow-up PRs. Thank you so much to everyone who's been working on this over the past months, especially @qingshi163 and @etaloof !

youknowone reacted with thumbs up emoji

arihant2math reacted with hooray emoji

arihant2math reacted with rocket emoji

All reactions

👍 1 reaction
🎉 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coolreader18 merged commit a6b4ef7 into RustPython:main

Mar 20, 2025

This was referenced Mar 20, 2025

Update to ruff_python_parser 0.11 #5615

Merged

[WIP] Use Ruff Parser #5423

Closed

youknowone commented Mar 20, 2025

Copy link

Copy Markdown

Member

Thank you all so much for this huge effort!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone mentioned this pull request

Mar 26, 2025

Replace parser #5299

Closed

This was referenced Apr 15, 2025

Publishing Internal Crates to crates.io astral-sh/ruff#10417

Closed

Enable installation via cargo astral-sh/ruff#43

Closed

Peter554 added a commit to Peter554/grimp that referenced this pull request

May 3, 2025


          Use ruff to parse imports

4ae107f

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

Peter554 mentioned this pull request

May 3, 2025

Use ruff to parse imports python-grimp/grimp#214

Merged

Peter554 added a commit to Peter554/grimp that referenced this pull request

May 3, 2025


          Use ruff to parse imports

081aa36

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

Peter554 added a commit to Peter554/grimp that referenced this pull request

May 3, 2025


          Use ruff to parse imports

567cefc

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

Peter554 added a commit to Peter554/grimp that referenced this pull request

May 3, 2025


          Use ruff to parse imports

e6d4183

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

Peter554 added a commit to Peter554/grimp that referenced this pull request

May 3, 2025


          Use ruff to parse imports

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

seddonym pushed a commit to Peter554/grimp that referenced this pull request

May 5, 2025


          Use ruff to parse imports

e4b7120

Ruff can be installed via git!

You may need to use CARGO_NET_GIT_FETCH_WITH_CLI=true

Inspired by RustPython/RustPython#5494

Reviewers

youknowone

youknowone left review comments

arihant2math

arihant2math left review comments

coolreader18

coolreader18 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

etaloof commented Jan 28, 2025

Uh oh!

coolreader18 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youknowone commented Mar 20, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coolreader18 commented Mar 20, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.