GeezerVison is showing github.com — typing upgrade to 3.13.2 by arihant2math · Pull Request #5590 · RustPython/RustPython
Conversation
arihant2math
commented
Mar 9, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
theoparis and starpit reacted with rocket emoji
|
The failing tests are unexpected success. Removing expectedFailure will fix them
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Rebasing has lead to an import error/compiler panic.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
That's because _py_exception_group.py is recently merged.
It uses those features form typing:
from typing import TYPE_CHECKING, Generic, Type, TypeVar, cast, overload
Any chance to break one of them?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
hmmm. Blocking on #5622, so I can rewrite that in rust.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Oh wait I can just break that import statement :D
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
arihant2math
commented
Apr 5, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Blocked on #5628 so I can atleast partially fix codegen.
(I need to use unit tests to see disassembly output)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Apr 14, 2025
|
One minor issue ... the pip install needs to be fixed. I can't really replicate on my machine because I'm on windows.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
resolve_mro fails
Traceback (most recent call last):
File "<stdin>", line 6, in <module>
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 224, in run_module
return _run_module_code(code, init_globals, run_name, mod_spec)
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 94, in _run_module_code
with _TempModule(mod_name) as temp_module, _ModifiedArgv0(fname):
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 97, in _run_module_code
mod_name, mod_spec, pkg_name, script_name)
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/__main__.py", line 24, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/cli/main.py", line 77, in main
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/commands/__init__.py", line 114, in create_command
File "~/Projects/RustPython/pylib/Lib/importlib/__init__.py", line 90, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "_frozen_importlib", line 1382, in _gcd_import
File "_frozen_importlib", line 1352, in _find_and_load
File "_frozen_importlib", line 1355, in _find_and_load
File "_frozen_importlib", line 1329, in _find_and_load_unlocked
File "_frozen_importlib", line 1326, in _find_and_load_unlocked
File "_frozen_importlib", line 1326, in _find_and_load_unlocked
File "_frozen_importlib", line 945, in _load_unlocked
File "_frozen_importlib", line 943, in _load_unlocked
File "_frozen_importlib", line 936, in _load_unlocked
File "_frozen_importlib", line 930, in _load_unlocked
File "_frozen_importlib_external", line 994, in exec_module
File "_frozen_importlib", line 488, in _call_with_frames_removed
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/commands/install.py", line 15, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/cli/req_command.py", line 26, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/operations/prepare.py", line 32, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/network/download.py", line 11, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_internal/cli/progress_bars.py", line 4, in <module>
File "/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl/pip/_vendor/rich/progress.py", line 273, in <module>
File "~/Projects/RustPython/pylib/Lib/_py_abc.py", line 36, in __new__
cls = super().__new__(mcls, name, bases, namespace, **kwargs)
TypeError: duplicate base class Generic
Traceback (most recent call last):
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 197, in _run_module_as_main
"__main__", mod_spec)
File "~/Projects/RustPython/pylib/Lib/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "~/Projects/RustPython/pylib/Lib/ensurepip/__main__.py", line 5, in <module>
sys.exit(ensurepip._main())
File "~/Projects/RustPython/pylib/Lib/ensurepip/__init__.py", line 290, in _main
default_pip=args.default_pip,
File "~/Projects/RustPython/pylib/Lib/ensurepip/__init__.py", line 167, in _bootstrap
with tempfile.TemporaryDirectory() as tmpdir:
File "~/Projects/RustPython/pylib/Lib/ensurepip/__init__.py", line 200, in _bootstrap
return _run_pip([*args, *_PACKAGE_NAMES], additional_paths)
File "~/Projects/RustPython/pylib/Lib/ensurepip/__init__.py", line 101, in _run_pip
return subprocess.run(cmd, check=True).returncode
File "~/Projects/RustPython/pylib/Lib/subprocess.py", line 548, in run
with Popen(*popenargs, **kwargs) as process:
File "~/Projects/RustPython/pylib/Lib/subprocess.py", line 572, in run
output=stdout, stderr=stderr)
CalledProcessError: (1, ['~/Projects/RustPython/target/debug/rustpython', '-W', 'ignore::DeprecationWarning', '-c', '\nimport runpy\nimport sys\nsys.path = [\'/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n/pip-23.2.1-py3-none-any.whl\'] + sys.path\nsys.argv[1:] = [\'install\', \'--no-cache-dir\', \'--no-index\', \'--find-links\', \'/var/folders/4l/db5by6f97gl8z692_wckqb3w0000gn/T/tmpp0rarl2n\', \'--upgrade\', \'pip\']\nrunpy.run_module("pip", run_name="__main__", alter_sys=True)\n'])
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
youknowone
commented
Apr 22, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
youknowone
commented
Apr 22, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Reproducible code
import typing
from typing import ContextManager, Generic, TextIO, BinaryIO
_I = typing.TypeVar("_I", TextIO, BinaryIO)
class _ReadContext(ContextManager[_I], Generic[_I]):
pass
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Finally, it all works.
Ready for review.
|
theoparis reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Even though there are regressions, merging this have benefits to fix pip
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|