GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add typing.Self by starpit · Pull Request #5710 · RustPython/RustPython

Conversation

@starpit

@starpit starpit commented Apr 17, 2025

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arihant2math

arihant2math commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Probably a good temporary fix.

See also: #5590
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented Apr 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since test_typing does not currently cover Self, please add a small test under extra_tests/snippets/stdlib_typing.py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@starpit

starpit commented Apr 18, 2025

Copy link
Copy Markdown
Author

thanks for the feedback. i agree that #5590 is a much better approach. in our case, Self is just one of many typing blockers...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented Apr 19, 2025

Copy link
Copy Markdown
Member

@starpit #5590 will take more time. I am going to merge this one first if you don't mind to add a test about this patch.
starpit reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@starpit

starpit commented Apr 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

fyi, #5711 is another blocker we ran into re: typing. Curious: is there some way we could offer to disable type checking?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@starpit
feat: add typing.Self
05b58db 
Signed-off-by: Nick Mitchell <[email protected]>
@starpit
starpit force-pushed the typing-self branch from b41c207 to 05b58db Compare April 19, 2025 09:51
@starpit

starpit commented Apr 19, 2025

Copy link
Copy Markdown
Author

https://github.com/starpit/RustPython/blob/typing-self/extra_tests/snippets/stdlib_typing.py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math

arihant2math commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

Closing, since other PR was merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math arihant2math closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@starpit @arihant2math @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.