GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lzma implementation by arihant2math · Pull Request #5717 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Based on #5709 because of the zlib abstraction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arihant2math arihant2math mentioned this pull request Apr 20, 2025
Switch to libbz2-rs-sys and finish bz2 impl #5709
Merged
@arihant2math
arihant2math marked this pull request as ready for review April 20, 2025 05:48
@arihant2math

arihant2math commented Apr 20, 2025

Copy link
Copy Markdown
Contributor Author

This turned out surprisingly effective, about 2/3s of the tests pass, which is enough for me at the moment. The main missing parts involve a bunch of unsafe things that xz2 doesn't really support (to my knowledge atleast).

As a side note I also abstracted out Compressor like Decompressor was abstracted
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
arihant2math force-pushed the lzma branch 2 times, most recently from c09442c to 2bad5d2 Compare April 21, 2025 00:01
@arihant2math
arihant2math marked this pull request as draft April 21, 2025 02:24
@arihant2math
arihant2math marked this pull request as ready for review April 21, 2025 02:24
@arihant2math

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

Lots of tests are failing because they were previously blocked due to no implementation at all.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math arihant2math changed the title Lzma implementation lzma implementation Apr 21, 2025
@arihant2math arihant2math added the A-stdlib label Apr 21, 2025
@coolreader18 coolreader18 mentioned this pull request Apr 21, 2025
Split out common compression routines into separate file #5728
Merged
@coolreader18

coolreader18 commented Apr 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Would you be able to squash these commits down? Ideally into one for copying the files from cpython, and one for all the rest?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

Sure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
arihant2math force-pushed the lzma branch 3 times, most recently from 19a43f5 to ca2dc44 Compare April 21, 2025 19:40
@arihant2math

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

It's at 3 now, I committed things in a weird fashion so I can't get it below that.
coolreader18 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
arihant2math requested a review from coolreader18 April 22, 2025 02:38
@arihant2math arihant2math mentioned this pull request Apr 23, 2025
3.13 Python Library update PRs #5736
Closed
@arihant2math
arihant2math requested a review from youknowone April 27, 2025 06:47
@arihant2math
arihant2math force-pushed the lzma branch from ca2dc44 to b6c0101 Compare April 30, 2025 06:53
youknowone
youknowone reviewed Apr 30, 2025
View reviewed changes
Comment thread Lib/tarfile.py Outdated
elif comptype == "xz":
try:
import lzma
# TODO: RUSTPYTHON remove underscore

@youknowone youknowone Apr 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this name changed to raise ImportError? What happens if it is lzma?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@arihant2math arihant2math Apr 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if left as is everything breaks because lzma is expected to be unimportable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@youknowone youknowone May 6, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xz seems to be not support. Added reason and avoided to use fake module name

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arihant2math reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@youknowone
youknowone force-pushed the lzma branch from f5400fa to a6a162e Compare May 6, 2025 05:32
youknowone
youknowone approved these changes May 6, 2025
View reviewed changes
@youknowone

youknowone commented May 6, 2025

Copy link
Copy Markdown
Member

oh no.. I thought #5728 and this one had shared work of the new compression module
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented May 6, 2025

Copy link
Copy Markdown
Member

@arihant2math What will be the best way? Is it worth to keep #5728?
if yes, the conflict need to be resolve.
if not, reverting it and merging this can be a way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math

arihant2math commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

Probably easiest to revert, yes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone and others added 3 commits May 7, 2025 15:01
@youknowone
Revert "Split out common compression routines into separate file (Rus…
48b08a2 
…tPython#5728)"

This reverts commit 9c88475.
@arihant2math @youknowone
add _lzma module with new dependency
2a1ea45 
Signed-off-by: Ashwin Naren <[email protected]>
@arihant2math @youknowone
add lzma.py and test_lzma.py at 3.13.2
2042d87 
Signed-off-by: Ashwin Naren <[email protected]>
arihant2math and others added 2 commits May 7, 2025 15:01
@arihant2math @youknowone
_lzma implementation and test marking
a501644 
Signed-off-by: Ashwin Naren <[email protected]>
@youknowone
more diff-friendly disabling xz
acae154
@youknowone
youknowone force-pushed the lzma branch from a6a162e to acae154 Compare May 7, 2025 06:01
@youknowone
flatten compression modules
d9c18c5
@youknowone
youknowone force-pushed the lzma branch from 663ce18 to d9c18c5 Compare May 7, 2025 06:42
@youknowone
youknowone merged commit 79646fd into RustPython:main May 7, 2025
@arihant2math
arihant2math deleted the lzma branch May 7, 2025 16:47
@youknowone youknowone mentioned this pull request Dec 4, 2025
Update Python libraries and tests from Python 3.13 #5529
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
@coolreader18 coolreader18 Awaiting requested review from coolreader18

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

A-stdlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@arihant2math @coolreader18 @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.