GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Split out common compression routines into separate file by coolreader18 · Pull Request #5728 · RustPython/RustPython

Conversation

@coolreader18

@coolreader18 coolreader18 commented Apr 21, 2025

Copy link
Copy Markdown
Member

Follow up to #5709. File structure is based on #5717, hopefully it should be mostly compatible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coolreader18
coolreader18 requested a review from arihant2math April 21, 2025 17:15
@coolreader18
Split out common compression routines into separate file
4f10cf0
@coolreader18
coolreader18 force-pushed the split-out-generic-compression branch from 7a8ef8c to 4f10cf0 Compare April 21, 2025 17:38
@arihant2math

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

I finally got that pr in a mergable state, hopefully it can be merged first for less conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arihant2math
arihant2math approved these changes Apr 21, 2025
View reviewed changes
youknowone
youknowone approved these changes Apr 22, 2025
View reviewed changes
Comment thread stdlib/src/compression/zlib.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .cspell.dict/rust-more.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
Apply suggestions from code review
e164655
@youknowone
youknowone force-pushed the split-out-generic-compression branch from 24527cd to e164655 Compare May 6, 2025 05:43
@youknowone
youknowone merged commit 9c88475 into RustPython:main May 6, 2025
@youknowone youknowone mentioned this pull request May 6, 2025
lzma implementation #5717
Merged
youknowone added a commit to arihant2math/RustPython that referenced this pull request May 7, 2025
@youknowone
Revert "Split out common compression routines into separate file (Rus…
48b08a2 
…tPython#5728)"

This reverts commit 9c88475.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
@arihant2math arihant2math arihant2math approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@coolreader18 @arihant2math @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.