GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implement nt.listvolumes by arihant2math · Pull Request #5730 · RustPython/RustPython

Conversation

@arihant2math

@arihant2math arihant2math commented Apr 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • nt.listvolumes
  • nt._path_exists and similar causes massive failures

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arihant2math
arihant2math force-pushed the more-os branch 2 times, most recently from bfcd5ab to 679af3f Compare April 21, 2025 19:29
@arihant2math
arihant2math marked this pull request as draft April 22, 2025 04:57
@arihant2math
arihant2math force-pushed the more-os branch from 679af3f to ba81e25 Compare April 27, 2025 06:19
@arihant2math
arihant2math marked this pull request as ready for review April 27, 2025 06:20
@youknowone youknowone changed the title More nt implementation nt.listvolumes Apr 28, 2025
@youknowone

youknowone commented Apr 28, 2025

Copy link
Copy Markdown
Member

nt._path_exists doesn't look like to be included here.
I will not retrigger CI because nt is not related to ubuntu build
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone
youknowone reviewed Apr 28, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there any related test for listvolumes?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread vm/src/stdlib/nt.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math

arihant2math commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

was there any related test for listvolumes?

Yes, but it requires a different os function that doesn't exist, so it still fails.
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arihant2math
arihant2math force-pushed the more-os branch from ba81e25 to 264e598 Compare April 30, 2025 06:55
@arihant2math
implement nt.listvolumes
4307205
@arihant2math
arihant2math force-pushed the more-os branch from 264e598 to 4307205 Compare April 30, 2025 06:57
@arihant2math arihant2math changed the title nt.listvolumes Implement nt.listvolumes Apr 30, 2025
youknowone
youknowone reviewed Apr 30, 2025
View reviewed changes
Comment thread vm/src/stdlib/nt.rs
#[pyfunction]
fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> {
let mut volumes = vec![];
let mut buffer = [0u16; 257];

@youknowone youknowone Apr 30, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is related to constant, is this possible?

Suggested change
let mut buffer = [0u16; 257];
let mut buffer = [0u16; MAX_PATH + 1];

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone

youknowone commented Dec 24, 2025

Copy link
Copy Markdown
Member

Thanks! #6373 added it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone youknowone closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arihant2math @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.