GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Implement nt.listvolumes by arihant2math · Pull Request #5730 · RustPython/RustPython

Implement nt.listvolumes #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

arihant2math wants to merge 1 commit into RustPython:main from arihant2math:more-os

Uh oh!

There was an error while loading. Please reload this page.

Closed

Implement nt.listvolumes #5730

Changes from all commits

Commits

Show all changes

1 commit

Select commit

4307205

implement nt.listvolumes

arihant2math Apr 21, 2025

File filter

Filter by extension .rs (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

34 changes: 34 additions & 0 deletions 34 vm/src/stdlib/nt.rs

Show comments

View file

Open in desktop

Original file line number

Diff line number

Diff line change

Expand Up

@@ -445,6 +445,39 @@ pub(crate) mod module {

Ok(vm.ctx.new_list(drives))

}

#[pyfunction]

fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> {

let mut volumes = vec![];

let mut buffer = [0u16; 257];

Comment thread

arihant2math marked this conversation as resolved.

Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

youknowone Apr 30, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is related to constant, is this possible?

Suggested change

	let mut buffer = [0u16; 257];
	let mut buffer = [0u16; MAX_PATH + 1];

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

let find = unsafe { FileSystem::FindFirstVolumeW(buffer.as_mut_ptr(), buffer.len() as _) };

if find == windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE {

return Err(errno_err(vm));

}

let mut err = 0;

while err == 0 {

let s = unsafe { widestring::WideCString::from_ptr_str(buffer.as_mut_ptr()) };

let s = s.to_string_lossy();

if s.is_empty() {

break;

}

volumes.push(s.to_string());

let ret = unsafe {

FileSystem::FindNextVolumeW(find, buffer.as_mut_ptr(), buffer.len() as _)

};

if ret == 0 {

err = std::io::Error::last_os_error().raw_os_error().unwrap_or(0);

}

if find != windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE {

unsafe { FileSystem::FindVolumeClose(find) };

}

if err != 0 && err != windows_sys::Win32::Foundation::ERROR_NO_MORE_FILES as i32 {

return Err(std::io::Error::from_raw_os_error(err).to_pyexception(vm));

}

let volumes: Vec<_> = volumes.into_iter().map(|v| vm.new_pyobj(v)).collect();

Ok(vm.ctx.new_list(volumes))

}

#[pyfunction]

fn set_handle_inheritable(

handle: intptr_t,

Expand Down

Expand Up

@@ -476,3 +509,4 @@ pub(crate) mod module {

Vec::new()

}

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.