GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Display logo on windows executable by arihant2math · Pull Request #5790 · RustPython/RustPython

Display logo on windows executable #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into RustPython:main from arihant2math:win-icon
Jun 28, 2025

Uh oh!

There was an error while loading. Please reload this page.

Merged

Display logo on windows executable #5790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da8971b
display logo on windows executable
arihant2math May 17, 2025
27e83c4
formatting
arihant2math Jun 28, 2025
e9edb19
apply suggestions
arihant2math Jun 28, 2025
bc564b0
Make clippy happy
arihant2math Jun 28, 2025
ca87498
rerun build.rs if logo is changed
arihant2math Jun 28, 2025
File filter
Filter by extension


Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Diff view
Diff view
Next Next commit
display logo on windows executable
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@arihant2math
arihant2math committed May 17, 2025
commit da8971b0601e36ed09437ea6ad3279e0ceb0774d

There are no files selected for viewing

0 .devcontainer/DOCKERFILE → .devcontainer/Dockerfile
Show comments
View file
Open in desktop
File renamed without changes.
70 changes: 70 additions & 0 deletions 70 Cargo.lock
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

3 changes: 3 additions & 0 deletions 3 Cargo.toml
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ ssl = ["rustpython-stdlib/ssl"]
ssl-vendor = ["ssl", "rustpython-stdlib/ssl-vendor"]
tkinter = ["rustpython-stdlib/tkinter"]

[build-dependencies]
winresource = "0.1"
Comment thread
arihant2math marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.


[dependencies]
rustpython-compiler = { workspace = true }
rustpython-pylib = { workspace = true, optional = true }
Expand Down
7 changes: 7 additions & 0 deletions 7 build.rs
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
fn main() {
if std::env::var("CARGO_CFG_TARGET_OS").unwrap() == "windows" {
Comment thread
arihant2math marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

let mut res = winresource::WindowsResource::new();
res.set_icon("logo.ico");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

res.compile().unwrap();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

}
}
Comment thread
arihant2math marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

Binary file added BIN +4.19 KB logo.ico
Show comments
View file
Open in desktop
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.