GeezerVison is showing github.com — Update `locale.py` from 3.13.6 and made `_locale` available on android by ShaharNaveh · Pull Request #6091 · RustPython/RustPython
Conversation
ShaharNaveh
commented
Aug 12, 2025
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
- New Features
- Enabled locale functionality on Android and other non‑iOS, non‑WASM platforms, expanding availability of locale-aware features.
- Bug Fixes
- Adjusted platform exposure of the LC_MESSAGES constant: now available on Unix systems except iOS and Redox, aligning behavior across supported platforms.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Aug 12, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Important
Review skipped
Review was skipped due to path filters
⛔ Files ignored due to path filters (1)
Lib/test/test__locale.py is excluded by !Lib/**
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Walkthrough
Relaxed cfg gates to enable the locale module and its initialization on Android (still excluded on iOS and wasm32). In locale.rs, LC_MESSAGES was moved out of the bulk libc import and re-exported under a narrower cfg (unix, not ios/redox), changing its platform exposure.
Changes
| Cohort / File(s) |
Summary of Changes |
Module gating and initialization
stdlib/src/lib.rs |
Adjusted cfg from not(any(ios, android, wasm32)) to not(any(ios, wasm32)) for mod locale and its registration in get_module_inits, enabling locale on Android. |
Locale constant export refactor
stdlib/src/locale.rs |
Removed LC_MESSAGES from the bulk #[pyattr] use libc::{...} block; reintroduced as a separately gated export #[cfg(all(unix, not(any(target_os = "ios", target_os = "redox"))))] #[pyattr] use libc::LC_MESSAGES;. Reordered remaining constants accordingly. |
Sequence Diagram(s)
sequenceDiagram
participant Runtime
participant ModuleInit as get_module_inits
participant Locale as locale (cfg-gated)
Runtime->>ModuleInit: Build module init list
alt not(iOS) and not(wasm32)
ModuleInit->>Locale: Include locale init (Android now included)
else
ModuleInit--xLocale: Exclude locale init
end
Runtime->>Runtime: Initialize enabled modules
Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
I twitch my ears at Android’s cheer,
Locale hops in, the path is clear.
LC_MESSAGES peeks—just so, not all—
Unix burrow, no iOS call.
With cfg trails and careful light,
I thump approval: builds feel right. 🐇✨
✨ Finishing Touches
🧪 Generate unit tests
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitai in a new review comment at the desired location with your query.
- PR comments: Tag
@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
- Add
@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
- Add
@coderabbitai anywhere in the PR title to generate the title automatically.
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|
youknowone
left a comment