GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Pin CI image to `windows-2025` by ShaharNaveh · Pull Request #6148 · RustPython/RustPython

Conversation

ShaharNaveh commented Sep 13, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Right now our tests are patched for windows-2025, and sometimes our runner gets the windows-2022 image which causes the CI to fail.
For more info see see:

https://github.blog/changelog/2025-07-31-github-actions-new-apis-and-windows-latest-migration-notice/#windows-latest-image-label-migration

Summary by CodeRabbit

Chores
- Updated CI runner configuration to standardize OS matrix formatting and temporarily adjust the Windows runner label. No impact on product behavior.
Tests
- Test workflows continue to run across macOS, Linux, and Windows with the updated runner labels and format. Test coverage and outcomes unchanged.
Note
- No user-facing changes in this release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Pin CI image to windows-2025

da06a7b

For more info see see:
https://github.blog/changelog/2025-07-31-github-actions-new-apis-and-windows-latest-migration-notice/

coderabbitai Bot commented Sep 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Walkthrough

Updated GitHub Actions CI matrix in .github/workflows/ci.yaml: replaced windows-latest with windows-2025 (with a TODO to revert on 2025/09/30) and converted inline OS arrays to block-style YAML sequences for rust_tests and snippets_cpython. (macOS and Ubuntu labels unchanged.)

Changes

Cohort / File(s)	Summary
CI workflow matrix updates `\.github/workflows/ci.yaml`	Converted inline OS arrays to block-style YAML sequences; replaced `windows-latest` with `windows-2025` in `rust_tests` and `snippets_cpython` job matrices and added TODO to switch back by 2025/09/30.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

youknowone

Poem

I hop through YAML fields at night,
Swapping runners till dawn's first light—
Windows 2025 takes flight,
A TODO carrot shining bright. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Pin CI image to `windows-2025`" concisely and accurately describes the primary change — pinning the Windows runner in the repository's GitHub Actions workflows to windows-2025, which matches the workflow edits and PR description. It is short, specific, and directly related to the changeset and does not include unnecessary detail. Minor YAML formatting updates in the workflows do not need to be reflected in the title.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da06a7b and 1d83188.

📒 Files selected for processing (1)

.github/workflows/ci.yaml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Run rust tests (windows-2025)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run snippets and cpython tests (windows-2025)
GitHub Check: Check Rust code with rustfmt and clippy
GitHub Check: Ensure compilation on various targets

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot reviewed

Sep 13, 2025

View reviewed changes

coderabbitai Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/ci.yaml (1)
246-249: Pin snippets_cpython matrix to windows-2025 (align Windows runner across CI)

Replace windows-latest with windows-2025 in the snippets_cpython matrix. Remaining occurrences found:

.github/workflows/ci.yaml:248 — matrix uses windows-latest (change this).

.github/workflows/ci.yaml:122 — already uses windows-2025 (TODO to switch back on 2025-09-30).

.github/workflows/release.yml:43 — runner: windows-latest (decide whether to pin).

Apply:
-        os: [macos-latest, ubuntu-latest, windows-latest]
+        os: [macos-latest, ubuntu-latest, windows-2025]

🧹 Nitpick comments (2)

.github/workflows/ci.yaml (2)
119-123: DRY the OS matrix via a YAML anchor to prevent drift.

Optional: define the OS list once here and reuse in other jobs.
-        os:
-          - macos-latest
-          - ubuntu-latest
-          - windows-2025 # TODO: Switch to `windows-latest` on 2025/09/30
+        os: &os_matrix
+          - macos-latest
+          - ubuntu-latest
+          - windows-2025 # TODO: Switch to `windows-latest` on 2025/09/30
Then in snippets_cpython:
-        os: [macos-latest, ubuntu-latest, windows-latest]
+        os: *os_matrix
122-122: Track the revert date.

Create a follow-up issue/reminder to switch back to windows-latest on 2025-09-30 to avoid forgetting the TODO.

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc4ebe6 and da06a7b.

📒 Files selected for processing (1)

.github/workflows/ci.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-07-11T09:35:43.571Z

Learnt from: ShaharNaveh
PR: RustPython/RustPython#5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions timeout-minutes field supports expressions that evaluate to integers, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}`, which will conditionally set different timeout values based on the runner OS.

Applied to files:

.github/workflows/ci.yaml

📚 Learning: 2025-07-11T09:35:43.571Z

Learnt from: ShaharNaveh
PR: RustPython/RustPython#5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions supports ternary-like expressions using `&&` and `||` operators in timeout-minutes. The syntax `${{ condition && value_if_true || value_if_false }}` is valid and commonly used, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}` which evaluates to 40 for Windows runners and 30 for others.

Applied to files:

.github/workflows/ci.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Check Rust code with rustfmt and clippy
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run rust tests (windows-2025)
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Ensure compilation on various targets
GitHub Check: Run rust tests (macos-latest)

🔇 Additional comments (1)

.github/workflows/ci.yaml (1)

119-123: Pin to windows-2025 looks good; timeout expression remains valid.

The matrix change achieves the PR goal for rust_tests, and contains(matrix.os, 'windows') still evaluates true for windows-2025, so timeouts behave as before.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Align images with all jobs

1d83188

youknowone approved these changes

Sep 13, 2025

View reviewed changes

youknowone merged commit 43d643a into RustPython:main

Sep 13, 2025

ShaharNaveh added a commit to ShaharNaveh/RustPython that referenced this pull request

Oct 5, 2025


          Revert "Pin CI image to windows-2025 (RustPython#6148)"

412fb7c

This reverts commit 43d643a.

ShaharNaveh mentioned this pull request

Oct 5, 2025

Revert "Pin CI image to windows-2025" #6182

Merged

youknowone pushed a commit that referenced this pull request

Oct 12, 2025


          Revert "Pin CI image to windows-2025 (#6148)" (#6182)

7986fee

This reverts commit 43d643a.

coderabbitai Bot mentioned this pull request

Jan 4, 2026

Update to windows-2025 runner on ci #5571

Merged

Reviewers

coderabbitai[bot]

coderabbitai[bot] left review comments

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ShaharNaveh commented Sep 13, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Sep 13, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Sep 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.