GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ruff for `Expr` parsing by ShaharNaveh · Pull Request #6207 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Reverts #6206

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShaharNaveh
Revert "Revert "Use ruff for Expr unparsing (RustPython#6124)""
30052d7 
This reverts commit 153d0ee.
@coderabbitai

coderabbitai Bot commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh
ShaharNaveh commented Oct 22, 2025
View reviewed changes
Comment thread Lib/test/test_future_stmt/test_future.py
)
return scope

@unittest.expectedFailure # TODO: RUSTPYTHON; 'a,' != '(a,)'

@ShaharNaveh ShaharNaveh Oct 22, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone should I open a feature request to ruff team about this? or should we just maintain our own fork of it? I am less in favor of maintaining a fork as it will require us:

  1. maintain a fork
  2. prevents us from publishing a new version to crates.io (unless we push the fork to crates.io)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@youknowone youknowone Oct 23, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a fork, write a feature but ask to merge it before using the fork. split the fork later when rejected. nothing to loose.
because we (and most of open source projects) always don't have enough engineering power for the project, upstreaming is the better choice when possible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@ShaharNaveh ShaharNaveh Oct 23, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope that they are fine with this astral-sh/ruff#21041

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShaharNaveh ShaharNaveh changed the title ruf for Expr uu parsing ruf for Expr parsing Oct 22, 2025
@ShaharNaveh ShaharNaveh changed the title ruf for Expr parsing ruff for Expr parsing Oct 22, 2025
@youknowone
youknowone force-pushed the main branch from d1c4925 to 3191eca Compare September 16, 2026 17:13
@youknowdot youknowdot mentioned this pull request Oct 28, 2026
Sync remaining call, buffer and annotation tests for Python 3.15 #9433
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.