GeezerVison

compiler/codegen/Cargo.toml (1)

34-34: Remove redundant dev-dependency on ruff_python_parser

It’s already a normal dependency due to compile-time usage; duplicating it in dev-deps is unnecessary.

 [dev-dependencies]
-ruff_python_parser = { workspace = true }
 insta = { workspace = true }

compiler/codegen/src/compile.rs (2)

150-162: Avoid reparsing for every unparse and stabilize line endings

Unconditionally reparsing "x = 1" on every call is unnecessary. Cache the computed indentation with OnceLock and force LF for reproducible output across platforms.

-fn unparse_expr(expr: &Expr) -> String {
-    // Hack, because we can't do `ruff_python_codegen::Indentation::default()`
-    // https://github.com/astral-sh/ruff/pull/20216
-    let indentation = {
-        let contents = r"x = 1";
-        let module = ruff_python_parser::parse_module(contents).unwrap();
-        let stylist = ruff_python_codegen::Stylist::from_tokens(module.tokens(), contents);
-        stylist.indentation().clone()
-    };
-
-    ruff_python_codegen::Generator::new(&indentation, LineEnding::default()).expr(expr)
-}
+fn unparse_expr(expr: &Expr) -> String {
+    static INDENT: std::sync::OnceLock<ruff_python_codegen::Indentation> =
+        std::sync::OnceLock::new();
+    let indentation = INDENT.get_or_init(|| {
+        // Hack, until Indentation::default() is available (see ruff PR #20216)
+        let contents = "x = 1";
+        let module = ruff_python_parser::parse_module(contents)
+            .expect("parse_module('x = 1') should never fail");
+        let stylist = ruff_python_codegen::Stylist::from_tokens(module.tokens(), contents);
+        stylist.indentation().clone()
+    });
+    ruff_python_codegen::Generator::new(indentation, LineEnding::Lf).expr(expr)
+}

---

3608-3616: Duplicate-key detection now relies on Ruff unparse; add coverage for semantic equivalence

Switching to Ruff’s generator likely normalizes literals (e.g., 1_0 vs 10, different string quotes). Please add/adjust tests to ensure duplicates are rejected based on semantic equality, not just textual quirks.

Would you like me to add regression tests covering numbers with underscores, different string quote styles, and mixed-case hex literals?

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.py : Use ruff for linting Python code