GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update ruff to `0.14.10` by ShaharNaveh · Pull Request #6271 · RustPython/RustPython

Conversation

ShaharNaveh commented Nov 15, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Summary by CodeRabbit

Chores
- Updated Ruff-related dependencies to version 0.14.10, including updates to the Python parser, AST, text size, and source file modules.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update ruff to 0.14.5

8c74eee

coderabbitai Bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

📝 Walkthrough

Walkthrough

This pull request updates Ruff-related dependencies in Cargo.toml from version 0.14.1 to 0.14.10. Four crates are bumped: ruff_python_parser, ruff_python_ast, ruff_text_size, and ruff_source_file. Their corresponding git revision hashes are updated to align with the new Ruff tag.

Changes

Cohort / File(s)	Summary
Ruff dependency version bumps `Cargo.toml`	Updated four Ruff-related dependencies (ruff_python_parser, ruff_python_ast, ruff_text_size, ruff_source_file) from tag 0.14.1 to 0.14.10 with corresponding git revision hash updates

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

[easy][minor] Freeze ruff libraries to the REV that the TAG points to. #6375: Updates the same four Ruff dependencies by changing their git ref values to newer versions.
Use ruff for Expr unparsing #6124: Modifies the same ruff_* crate versions in dependency management for Expr unparsing functionality.
Configure dependabot to ignore ruff updates #6185: Adds dependabot ignore rules for the same ruff_* dependencies that are being updated here.

Suggested reviewers

youknowone

Poem

🐰 Ruff edges smoothed with a gentle hop,
From 0.14.1 to ten we did not stop,
Four crates aligned in perfect time,
Dependencies dance—a parser's rhyme! ✨

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update ruff to `0.14.10`' directly and clearly summarizes the main change in the pull request: bumping the ruff dependency from version 0.14.1 to 0.14.10.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3afd46 and 389d9d7.

⛔ Files ignored due to path filters (2)

Cargo.lock is excluded by !**/*.lock
Lib/test/test_syntax.py is excluded by !Lib/**

📒 Files selected for processing (1)

Cargo.toml

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-12-27T14:03:49.034Z

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Applied to files:

Cargo.toml

📚 Learning: 2025-12-27T14:03:49.034Z

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: RustPython is a Python 3 interpreter written in Rust implementing Python 3.13.0+ compatibility with complete Python environment in Rust (not CPython bindings), clean implementation without compatibility hacks, and cross-platform support including WebAssembly compilation

Applied to files:

Cargo.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run snippets and cpython tests (windows-latest)

🔇 Additional comments (2)

Cargo.toml (2)

154-159: Commit hash verified against ruff tag 0.14.10.

The commit hash 45bbb4cbffe73cf925d4579c2e3eb413e0539390 correctly corresponds to ruff tag 0.14.10. All four ruff crate dependencies are pinned to the same commit hash, which ensures consistent versions and reproducible builds.

154-159: ruff 0.14.10 upgrade is safe—no breaking changes or security vulnerabilities in this version.

Verification shows:

No breaking changes in 0.14.10 (the breaking change for Python 3.14 default was introduced in 0.14.0)

No security advisories for 0.14.10; CVE-2025-62518 was fixed in 0.14.2, well before this version

The specific test failure reference (PR #21163) could not be verified in public sources, but the codebase appropriately manages failing tests through test markers as seen in recent commits

The commit hash approach for reproducible builds is sound.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone commented Nov 15, 2025

Copy link

Copy Markdown

Member

test_syntax is broken

ShaharNaveh reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge remote-tracking branch 'upstream/main' into update-ruff-0-14-5

257e283

ShaharNaveh commented Nov 15, 2025

Copy link

Copy Markdown

Contributor Author

Seems to be related to: astral-sh/ruff#21163 which is included in 0.14.4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh added 2 commits

November 21, 2025 12:24


          Merge remote-tracking branch 'upstream/main' into update-ruff-0-14-5

9b9251c


          Update Cargo.lock

89bc1e7

ShaharNaveh marked this pull request as draft

November 26, 2025 10:51

youknowone commented Dec 30, 2025

Copy link

Copy Markdown

Member

lets mark it as expected failure and merge this. it doesn't hurt user experience.

ShaharNaveh reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh added 4 commits

December 31, 2025 12:36


          Merge remote-tracking branch 'upstream/main' into update-ruff-0-14-5

0c50666


          Update ruff to 0.14.10

789f25a


          Update Cargo.lock

f88203a


          Mark failing test

389d9d7

ShaharNaveh changed the title ~~Update ruff to 0.14.5~~ Update ruff to 0.14.10

Dec 31, 2025

ShaharNaveh marked this pull request as ready for review

December 31, 2025 11:13

ShaharNaveh requested a review from youknowone

December 31, 2025 11:23

youknowone approved these changes

Dec 31, 2025

View reviewed changes

youknowone left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone merged commit 6ccf3b5 into RustPython:main

Dec 31, 2025

13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot mentioned this pull request

Jan 24, 2026

Update to ruff 0.14.14 #6861

Merged

This was referenced Feb 11, 2026

Update ruff to 0.15.0 #7086

Merged

Update ruff to 0.15.1 #7105

Merged

coderabbitai Bot mentioned this pull request

Feb 27, 2026

Update ruff to 0.15.4 #7246

Merged

Reviewers

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ShaharNaveh commented Nov 15, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks

Uh oh!

youknowone commented Nov 15, 2025

Uh oh!

ShaharNaveh commented Nov 15, 2025

Uh oh!

youknowone commented Dec 30, 2025

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Nov 15, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.