GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Updated the pkgutil + unittest libraries + the pkgutil, unittest and import tests - v.3.13.11 by terryluan12 · Pull Request #6610 · RustPython/RustPython

Conversation

terryluan12 commented Dec 31, 2025

Copy link

Copy Markdown

Contributor

I don't have access to Windows for now, so I've added comments to the top of the relevant test_pathlib files

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone reacted with thumbs up emoji

All reactions

👍 1 reaction

coderabbitai Bot commented Dec 31, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (22)

Lib/pkgutil.py is excluded by !Lib/**
Lib/test/test_import/__init__.py is excluded by !Lib/**
Lib/test/test_import/data/circular_imports/import_cycle.py is excluded by !Lib/**
Lib/test/test_import/data/circular_imports/singlephase.py is excluded by !Lib/**
Lib/test/test_import/data/double_const.py is excluded by !Lib/**
Lib/test/test_import/data/package3/__init__.py is excluded by !Lib/**
Lib/test/test_import/data/package3/submodule.py is excluded by !Lib/**
Lib/test/test_import/data/package4/__init__.py is excluded by !Lib/**
Lib/test/test_import/data/package4/submodule.py is excluded by !Lib/**
Lib/test/test_pkgutil.py is excluded by !Lib/**
Lib/test/test_unittest/test_async_case.py is excluded by !Lib/**
Lib/test/test_unittest/test_discovery.py is excluded by !Lib/**
Lib/test/test_unittest/test_loader.py is excluded by !Lib/**
Lib/test/test_unittest/test_program.py is excluded by !Lib/**
Lib/test/test_unittest/test_runner.py is excluded by !Lib/**
Lib/test/test_unittest/testmock/testasync.py is excluded by !Lib/**
Lib/test/test_unittest/testmock/testhelpers.py is excluded by !Lib/**
Lib/test/test_unittest/testmock/testpatch.py is excluded by !Lib/**
Lib/unittest/__init__.py is excluded by !Lib/**
Lib/unittest/async_case.py is excluded by !Lib/**
Lib/unittest/loader.py is excluded by !Lib/**
Lib/unittest/main.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryluan12 mentioned this pull request

Dec 31, 2025

Update Straightforward packages Pt 2 #6599

Closed

terryluan12 changed the title ~~Updated the pkgutil + pathlib libraries~~ Updated the pkgutil, pathlib, importlib + unittest libraries

Dec 31, 2025

terryluan12 changed the title ~~Updated the pkgutil, pathlib, importlib + unittest libraries~~ Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries

Dec 31, 2025

terryluan12 changed the title ~~Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries~~ Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries - v.3.13.10

Dec 31, 2025

youknowone commented Jan 1, 2026

Copy link

Copy Markdown

Member

dbm is updated in #6616
shelve will be updated in #6483

terryluan12 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fanninpm mentioned this pull request

Jan 2, 2026

Update Python libraries and tests from Python 3.13 #5529

Closed

terryluan12 commented Jan 3, 2026

Copy link

Copy Markdown

Contributor Author

dbm is updated in #6616 shelve will be updated in #6483

Sounds good. Removed from the title. Is there anything else I should do?

Also as an FYI, _test_multiprocessing.py is failing now, so I'm updating _test_multiprocessing.py + the multiprocessing library

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryluan12 changed the title ~~Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries - v.3.13.10~~ Updated the pkgutil, pathlib, importlib, multiprocessing & unittest libraries - v.3.13.10

Jan 3, 2026

youknowone commented Jan 3, 2026

Copy link

Copy Markdown

Member

@terryluan12 Thank you so much! Could you also rebase this to remove test_import, which is already merged? And I recently updated multiprocessing to 3.13.11. Could you also check again if it is patching backward?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryluan12 commented Jan 3, 2026

Copy link

Copy Markdown

Contributor Author

@youknowone taking a look, I think I may completely refactor the history, as pathlib and importlib was already imported, which means quite a lot of refactoring would need to be done anyways. Can you clarify, do you mean importlib? Taking a look, it actually seems like importlib was updated, but not test_import

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone commented Jan 3, 2026

Copy link

Copy Markdown

Member

Using git reset to prev commit and adding only indented files will be helpful. Then cherrypick or rebase will be easy

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryluan12 force-pushed the update_pkgutil_pathlib branch 2 times, most recently from d35f1ec to 6a06f94 Compare

January 3, 2026 06:30

terryluan12 changed the title ~~Updated the pkgutil, pathlib, importlib, multiprocessing & unittest libraries - v.3.13.10~~ Updated the pkgutil + unittest libraries + the pkgutil, unittest and import tests - v.3.13.11

Jan 3, 2026

terryluan12 added 5 commits

January 4, 2026 09:18


          Updated unittest + tests

efda0f3


          Updated pkgutil + the associated test

b136a44


          Updated test_import

d41112b


          Fixed import + unittest test errors

f3ed7e2


          Updated test_dll_dependency_import with expectedFailure

b4ce088

youknowone approved these changes

Jan 4, 2026

View reviewed changes

youknowone left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone force-pushed the update_pkgutil_pathlib branch from 08f156f to b4ce088 Compare

January 4, 2026 00:23

youknowone merged commit 4bec6bb into RustPython:main

Jan 4, 2026

12 of 13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

terryluan12 added a commit to terryluan12/RustPython that referenced this pull request

Jan 5, 2026


          Updated the pkgutil + unittest libraries + the pkgutil, unittest and …

4185dc9

…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure

terryluan12 added a commit to terryluan12/RustPython that referenced this pull request

Jan 5, 2026


          Updated the pkgutil + unittest libraries + the pkgutil, unittest and …

ca28ddd

…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure

terryluan12 added a commit to terryluan12/RustPython that referenced this pull request

Jan 5, 2026


          Updated the pkgutil + unittest libraries + the pkgutil, unittest and …

a733b8d

…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure

terryluan12 deleted the update_pkgutil_pathlib branch

January 5, 2026 19:06

Reviewers

youknowone

youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

terryluan12 commented Dec 31, 2025

Uh oh!

coderabbitai Bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

youknowone commented Jan 1, 2026

Uh oh!

terryluan12 commented Jan 3, 2026

Uh oh!

youknowone commented Jan 3, 2026

Uh oh!

terryluan12 commented Jan 3, 2026

Uh oh!

youknowone commented Jan 3, 2026

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Dec 31, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.