GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated token + weakref libraries + weakref test - v3.13.11 by terryluan12 · Pull Request #6633 · RustPython/RustPython

Conversation

@terryluan12

@terryluan12 terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Jan 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • Lib/test/_test_multiprocessing.py is excluded by !Lib/**
  • Lib/test/test_weakref.py is excluded by !Lib/**
  • Lib/token.py is excluded by !Lib/**
  • Lib/weakref.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryluan12 terryluan12 changed the title Updated token + weakref libraries Updated token + weakref libraries + weakref test Jan 3, 2026
@terryluan12

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

I could not find a token test file
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone

youknowone commented Jan 3, 2026

Copy link
Copy Markdown
Member

by searching import token, test_tokenize seems to test it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryluan12

terryluan12 commented Jan 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

by searching import token, test_tokenize seems to test it

I saw that, & assumed that it would test out the tokenize library, but as I'm writing it out I'm realizing I should probably jointly update the two libraries. Will add it, thanks!
youknowone reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryluan12 terryluan12 changed the title Updated token + weakref libraries + weakref test Updated token + weakref libraries + weakref test - v3.13.11 Jan 3, 2026
@terryluan12

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

So it seems a rewrite of tokenize has been done. the _tokenize function was moved to a precompiled library, and logic has been changed, so it's not as simple as keeping the older _tokenize version. Is it okay to merge, without making any tokenization migrations?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryluan12

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

It's a bit of a different error, but waiting until #6635 is merged until debugging
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryluan12 terryluan12 mentioned this pull request Jan 3, 2026
Update Straightforward packages Pt 3 #6600
Closed
terryluan12 added 5 commits January 4, 2026 09:25
@terryluan12 @youknowone
Updated the token library
7f6ebe4
@terryluan12 @youknowone
Updated the weakref library
7c794ec
@terryluan12 @youknowone
Annotated the failing weakref test
7dc8258
@terryluan12 @youknowone
Fixed test issues with mac
98782ef
@terryluan12 @youknowone
Added sys import into ftplib
c961277
@youknowone
youknowone force-pushed the update_token_weakref branch from cd1bf05 to c961277 Compare January 4, 2026 00:27
youknowone
youknowone reviewed Jan 4, 2026
View reviewed changes
Comment thread Lib/test/test_ftplib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
Apply suggestion from @youknowone
2af0b72
youknowone
youknowone approved these changes Jan 4, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
youknowone merged commit 68d65a7 into RustPython:main Jan 4, 2026
12 of 13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated token + weakref libraries + weakref test - v3.13.11 (RustPyth…
313e630 
…on#6633)

* Updated the token library

* Updated the weakref library

* Annotated the failing weakref test
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated token + weakref libraries + weakref test - v3.13.11 (RustPyth…
211f508 
…on#6633)

* Updated the token library

* Updated the weakref library

* Annotated the failing weakref test
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated token + weakref libraries + weakref test - v3.13.11 (RustPyth…
e4d29fd 
…on#6633)

* Updated the token library

* Updated the weakref library

* Annotated the failing weakref test
@terryluan12
terryluan12 deleted the update_token_weakref branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@terryluan12 @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.