GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -1459,7 +1459,7 @@ def _acquire_release(lock, timeout, l=None, n=1):
		for _ in range(n):
		lock.release()

		@unittest.expectedFailureIf(sys.platform == "darwin", "TODO: RUSTPYTHON")
		@unittest.skipIf(sys.platform == 'darwin', "TODO: RUSTPYTHON; flaky on darwin")
		def test_repr_rlock(self):
		if self.TYPE != 'processes':
		self.skipTest('test not appropriate for {}'.format(self.TYPE))
Expand Down

24 changes: 2 additions & 22 deletions 24 Lib/test/test_ftplib.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -593,31 +593,24 @@ def test_quit(self):
		def test_abort(self):
		self.client.abort()

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_retrbinary(self):
		received = []
		self.client.retrbinary('retr', received.append)
		self.check_data(b''.join(received),
		RETR_DATA.encode(self.client.encoding))

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_retrbinary_rest(self):
		for rest in (0, 10, 20):
		received = []
		self.client.retrbinary('retr', received.append, rest=rest)
		self.check_data(b''.join(received),
		RETR_DATA[rest:].encode(self.client.encoding))

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_retrlines(self):
		received = []
		self.client.retrlines('retr', received.append)
		self.check_data(''.join(received), RETR_DATA.replace('\r\n', ''))

		@unittest.skip('TODO: RUSTPYTHON; weird limiting to 8192, something w/ buffering?')
		def test_storbinary(self):
		f = io.BytesIO(RETR_DATA.encode(self.client.encoding))
		self.client.storbinary('stor', f)
Expand All		@@ -629,8 +622,6 @@ def test_storbinary(self):
		self.client.storbinary('stor', f, callback=lambda x: flag.append(None))
		self.assertTrue(flag)

		@unittest.skip('TODO: RUSTPYTHON')
		# ssl_error.SSLWantReadError: The operation did not complete (read)
		def test_storbinary_rest(self):
		data = RETR_DATA.replace('\r\n', '\n').encode(self.client.encoding)
		f = io.BytesIO(data)
Expand All		@@ -639,8 +630,6 @@ def test_storbinary_rest(self):
		self.client.storbinary('stor', f, rest=r)
		self.assertEqual(self.server.handler_instance.rest, str(r))

		@unittest.skip('TODO: RUSTPYTHON')
		# ssl_error.SSLWantReadError: The operation did not complete (read)
		def test_storlines(self):
		data = RETR_DATA.replace('\r\n', '\n').encode(self.client.encoding)
		f = io.BytesIO(data)
Expand All		@@ -658,21 +647,15 @@ def test_storlines(self):
		with warnings_helper.check_warnings(('', BytesWarning), quiet=True):
		self.assertRaises(TypeError, self.client.storlines, 'stor foo', f)

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_nlst(self):
		self.client.nlst()
		self.assertEqual(self.client.nlst(), NLST_DATA.split('\r\n')[:-1])

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_dir(self):
		l = []
		self.client.dir(l.append)
		self.assertEqual(''.join(l), LIST_DATA.replace('\r\n', ''))

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_mlsd(self):
		list(self.client.mlsd())
		list(self.client.mlsd(path='/'))
Expand Down Expand Up		@@ -859,8 +842,6 @@ def test_storlines_too_long(self):
		f = io.BytesIO(b'x' * self.client.maxline * 2)
		self.assertRaises(ftplib.Error, self.client.storlines, 'stor', f)

		@unittest.skip('TODO: RUSTPYTHON')
		# TimeoutError: The read operation timed out
		def test_encoding_param(self):
		encodings = ['latin-1', 'utf-8']
		for encoding in encodings:
Expand Down Expand Up		@@ -922,6 +903,7 @@ def retr():
		retr()


		@unittest.skip("TODO: RUSTPYTHON; SSL + asyncore has problem")
		@skipUnless(ssl, "SSL not available")
		@requires_subprocess()
		class TestTLS_FTPClassMixin(TestFTPClass):
Expand All		@@ -940,7 +922,7 @@ def setUp(self, encoding=DEFAULT_ENCODING):


		@skipUnless(ssl, "SSL not available")
		@unittest.skip("TODO: RUSTPYTHON; SSL + asyncore has problem on darwin")
		@unittest.skip("TODO: RUSTPYTHON; SSL + asyncore has problem")
		@requires_subprocess()
		class TestTLS_FTPClass(TestCase):
		"""Specific TLS_FTP class tests."""
Expand Down Expand Up		@@ -1025,8 +1007,6 @@ def test_context(self):
		self.assertIs(sock.context, ctx)
		self.assertIsInstance(sock, ssl.SSLSocket)

		@unittest.skip('TODO: RUSTPYTHON')
		# ssl_error.SSLWantReadError: The operation did not complete (read)
		def test_ccc(self):
		self.assertRaises(ValueError, self.client.ccc)
		self.client.login(secure=True)
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.