GeezerVison

Reviewing files that changed from the base of the PR and between eee3608 and b95199b.

• Lib/re/__init__.py is excluded by !Lib/**
• Lib/re/_casefix.py is excluded by !Lib/**
• Lib/re/_compiler.py is excluded by !Lib/**
• Lib/re/_constants.py is excluded by !Lib/**
• Lib/re/_parser.py is excluded by !Lib/**
• Lib/sre_constants.py is excluded by !Lib/**
• Lib/test/test_re.py is excluded by !Lib/**
• Lib/test/test_runpy.py is excluded by !Lib/**
• Lib/test/test_socket.py is excluded by !Lib/**
• Lib/test/test_unittest/test_async_case.py is excluded by !Lib/**
• Lib/test/test_zipfile/_path/test_path.py is excluded by !Lib/**
• Lib/test/test_zipfile/test_core.py is excluded by !Lib/**
• Lib/test/test_zipimport.py is excluded by !Lib/**
• Lib/test/zipimport_data/sparse-zip64-c0-0x000000000.part is excluded by !Lib/**
• Lib/test/zipimport_data/sparse-zip64-c0-0x100000000.part is excluded by !Lib/**
• Lib/test/zipimport_data/sparse-zip64-c0-0x200000000.part is excluded by !Lib/**
• Lib/zipfile/__init__.py is excluded by !Lib/**
• Lib/zipimport.py is excluded by !Lib/**

• crates/sre_engine/src/constants.rs
• crates/vm/src/stdlib/sre.rs
• scripts/generate_sre_constants.py

• crates/vm/src/stdlib/sre.rs

• GitHub Check: Run rust tests (macos-latest)
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Run rust tests (ubuntu-latest)
• GitHub Check: Ensure compilation on various targets
• GitHub Check: Check Rust code with clippy
• GitHub Check: Run snippets and cpython tests on wasm-wasi
• GitHub Check: Check the WASM package and demo

crates/sre_engine/src/constants.rs (4)

6-7: LGTM! Clear documentation of auto-generation.

The header correctly indicates this file is auto-generated from Python source, which helps prevent inadvertent manual edits and improves maintainability.

---

65-121: LGTM! Improved code organization.

The additional blank lines between enum and bitflags definitions improve readability and align with Rust formatting conventions.

---

108-120: TEMPLATE flag removal is complete and has no breaking references.

The TEMPLATE flag has been successfully removed from SreFlag, and verification confirms no remaining references to SRE_FLAG_TEMPLATE or re.TEMPLATE exist in the codebase. This aligns with Python's deprecation of the flag in 3.6+.

---

16-16: Verify SRE_MAGIC aligns with the target CPython version being synchronized.

The SRE_MAGIC constant is a version identifier for the regex engine and is properly exported to the Python layer as MAGIC in the sre module. Changing this value could affect regex pattern compilation compatibility.

Confirm that the value 20230612 matches the SRE_MAGIC in the specific CPython version (3.12 or 3.13) being synchronized. Check the target CPython source or run python -c "import _sre; print(_sre.MAGIC)" on the target version to verify alignment.

Note: The .pyc file references in the codebase are for Python bytecode, not regex pattern caches, so the primary concern is ensuring the engine version is compatible with the source being synchronized.

scripts/generate_sre_constants.py (3)

1-5: LGTM! Clear script identification.

The shebang and documentation clearly identify the script's purpose and usage.

---

85-132: Build script with trusted input - exec() usage is acceptable.

The exec() call on line 92 executes code from Lib/re/_constants.py. While exec() generally poses security risks, this is acceptable here because:

1. The input file is part of the trusted codebase
2. This is a build-time script run by developers, not production code
3. The script's purpose is to read Python constants and generate Rust code

The generated constants correctly match the structure in constants.rs.

---

141-184: Remove commented-out code.

This large block of commented-out code should be removed. Version control preserves history if needed, and dead code reduces maintainability. Additionally, the hardcoded list at lines 158-168 includes the now-deprecated TEMPLATE flag, making it outdated.

🔎 Remove dead code

-
-#         dump(f, OPCODES, "SreOpcode", "u32", "")
-#         dump(f, ATCODES, "SreAtCode", "u32", "AT_")
-#         dump(f, CHCODES, "SreCatCode", "u32", "CATEGORY_")
-#
-#         def bitflags(typ, int_t, prefix, flags):
-#             f.write(f"""\
-# bitflags! {{
-#     pub struct {typ}: {int_t} {{
-# """)
-#             for name in flags:
-#                 val = globals()[prefix + name]
-#                 f.write(f"        const {name} = {val};\n")
-#             f.write("""\
-#     }
-# }
-# """)
-#
-#         bitflags("SreFlag", "u16", "SRE_FLAG_", [
-#             "TEMPLATE",
-#             "IGNORECASE",
-#             "LOCALE",
-#             "MULTILINE",
-#             "DOTALL",
-#             "UNICODE",
-#             "VERBOSE",
-#             "DEBUG",
-#             "ASCII",
-#         ])
-#
-#         bitflags("SreInfo", "u32", "SRE_INFO_", [
-#             "PREFIX", "LITERAL", "CHARSET",
-#         ])
-#
-#     print("done")
-
-
-# if __name__ == "__main__":
-#     import sys
-#     if len(sys.argv) > 1:
-#         constants_file = sys.argv[1]
-#     else:
-#         import os
-#         constants_file = os.path.join(os.path.dirname(__file__), "../../sre-engine/src/constants.rs")
-#     with open(constants_file, "w") as f:

Likely an incorrect or invalid review comment.

Reviewing files that changed from the base of the PR and between b95199b and 1c44c43.

• scripts/generate_sre_constants.py

• GitHub Check: Run rust tests (macos-latest)
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Run snippets and cpython tests (macos-latest)
• GitHub Check: Run snippets and cpython tests (windows-latest)
• GitHub Check: Ensure compilation on various targets

Reviewing files that changed from the base of the PR and between 1c44c43 and deb1063.

• scripts/generate_sre_constants.py

• GitHub Check: Run rust tests (ubuntu-latest)
• GitHub Check: Run rust tests (windows-latest)
• GitHub Check: Run rust tests (macos-latest)
• GitHub Check: Run snippets and cpython tests (windows-latest)
• GitHub Check: Check Rust code with clippy
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Ensure compilation on various targets
• GitHub Check: Run snippets and cpython tests (macos-latest)
• GitHub Check: Check the WASM package and demo

scripts/generate_sre_constants.py (4)

1-5: LGTM!

Clear script header with appropriate shebang and documentation.

---

7-16: LGTM!

The idempotent file update logic is well-implemented, only writing when content actually changes.

---

19-33: LGTM!

Appropriate copyright header for generated Rust code.

---

60-83: LGTM!

The bitflags generation logic correctly preserves original values from the dictionary.