GeezerVison

crates/stdlib/src/opcode.rs (2)

56-132: Consider eliminating double conversion in has_* functions.

All the has_* functions (lines 56-132) call Self::is_valid(opcode) which internally performs Instruction::try_from(opcode as u8).is_ok(), then immediately call Instruction::try_from(opcode as u8) again in the matches! macro. This double conversion is inefficient.

Consider inlining the range check and performing a single conversion:

🔎 Example refactor for has_const

 pub fn has_const(opcode: i32) -> bool {
-    Self::is_valid(opcode)
-        && matches!(
-            Instruction::try_from(opcode as u8),
-            Ok(Instruction::LoadConst { .. } | Instruction::ReturnConst { .. })
-        )
+    (0..=255).contains(&opcode)
+        && matches!(
+            Instruction::try_from(opcode as u8),
+            Ok(Instruction::LoadConst { .. } | Instruction::ReturnConst { .. })
+        )
 }

Apply the same pattern to has_name, has_jump, has_free, and has_local.

---

158-176: Optional: Simplify redundant error handling for oparg.

After the fast_isinstance check on line 161 confirms the value is an int type, the downcast_ref on line 167 should always succeed. The ok_or_else on lines 168-173 provides defensive error handling with the same error message, but is likely redundant.

🔎 Simplified approach

 let oparg = args
     .oparg
     .map(|v| {
         if !v.fast_isinstance(vm.ctx.types.int_type) {
             return Err(vm.new_type_error(format!(
                 "'{}' object cannot be interpreted as an integer",
                 v.class().name()
             )));
         }
         v.downcast_ref::<PyInt>()
-            .ok_or_else(|| {
-                vm.new_type_error(format!(
-                    "'{}' object cannot be interpreted as an integer",
-                    v.class().name()
-                ))
-            })?
+            .expect("downcast should succeed after isinstance check")
             .try_to_primitive::<u32>(vm)
     })
     .unwrap_or(Ok(0))?;

Alternatively, keep the defensive check if there are VM edge cases where isinstance and downcast might diverge.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro