GeezerVison is showing github.com — Update ruff to 0.14.11 in the CI by ShaharNaveh · Pull Request #6708 · RustPython/RustPython
Conversation
ShaharNaveh
commented
Jan 11, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
ref: #6707 (comment)
Summary by CodeRabbit
-
Chores
- Updated code quality tool version in CI workflows.
-
Style
- Reorganized imports in test utilities script.
✏️ Tip: You can customize this high-level summary in your review settings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Code has been automatically formatted
The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:
git pull origin CI-update-ruff |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Jan 11, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
📝 Walkthrough
Walkthrough
Updates ruff-action version from 0.14.9 to 0.14.11 in two CI workflow files and reorders imports in a Python script. All changes are minor version/configuration updates with no functional behavioral modifications.
Changes
| Cohort / File(s) |
Summary |
CI Workflow Version Bumps
.github/workflows/ci.yaml, .github/workflows/pr-auto-commit.yaml |
Bumps astral-sh/ruff-action dependency from version 0.14.9 to 0.14.11 in both workflow files. No changes to workflow structure or execution logic. |
Script Import Reordering
scripts/fix_test.py |
Reorders imports from lib_updater: changes order from apply_patches, PatchSpec, UtMethod to PatchSpec, UtMethod, apply_patches. No runtime impact. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
🐰 A rabbit hops with glee,
Ruff bumped to .14.11, naturally,
Imports shuffle-sorted with care,
Tiny tweaks float through the air! ✨
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name |
Status |
Explanation |
Resolution |
| Docstring Coverage |
⚠️ Warning |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. |
Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
✅ Passed |
The pull request title accurately describes the main change: updating ruff-action from 0.14.9 to 0.14.11 in CI workflow files. It is concise, clear, and directly reflects the primary modification. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📜 Recent review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 29bb8b4 and 32edf7b.
📒 Files selected for processing (3)
.github/workflows/ci.yaml.github/workflows/pr-auto-commit.yamlscripts/fix_test.py
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.py: In most cases, Python code should not be edited; bug fixes should be made through Rust code modifications only
Follow PEP 8 style for custom Python code
Use ruff for linting Python code
Files:
**/*test*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*test*.py: NEVER comment out or delete any test code lines except for removing @unittest.expectedFailure decorators and upper TODO comments
NEVER modify test assertions, test logic, or test data in test files
When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason; do not comment it out
The only acceptable modifications to test files are: (1) Removing @unittest.expectedFailure decorators and the upper TODO comments when tests actually pass, and (2) Adding @unittest.expectedFailure decorators when tests cannot be fixed
Files:
🧠 Learnings (2)
📚 Learning: 2025-12-27T14:03:49.034Z
Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: Applies to **/*.py : Use ruff for linting Python code
Applied to files:
.github/workflows/pr-auto-commit.yaml.github/workflows/ci.yaml
📚 Learning: 2025-08-30T14:40:05.858Z
Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 6089
File: scripts/lib_updater.py:292-297
Timestamp: 2025-08-30T14:40:05.858Z
Learning: In scripts/lib_updater.py, the --inplace flag intentionally writes to orig_file (not remote_file) even though patches are applied to remote_file content. This workflow allows updating the original RustPython test file with patches applied to new upstream CPython content.
Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Run snippets and cpython tests (macos-latest)
- GitHub Check: Run snippets and cpython tests (ubuntu-latest)
- GitHub Check: Run snippets and cpython tests (windows-2025)
- GitHub Check: Run rust tests (windows-2025)
- GitHub Check: Run rust tests (ubuntu-latest)
- GitHub Check: Run snippets and cpython tests on wasm-wasi
- GitHub Check: Ensure compilation on various targets
- GitHub Check: Run rust tests (macos-latest)
- GitHub Check: Run tests under miri
- GitHub Check: Check Rust code with clippy
- GitHub Check: Check the WASM package and demo
🔇 Additional comments (3)
scripts/fix_test.py (1)
30-30: LGTM! Import ordering follows ruff conventions.
The alphabetical reordering of imports is consistent with ruff's isort rule and represents no functional change.
.github/workflows/pr-auto-commit.yaml (1)
45-45: LGTM! Consistent ruff version upgrade.
The ruff version update to 0.14.11 is consistent with the change in ci.yaml, ensuring uniform linting across CI workflows.
.github/workflows/ci.yaml (1)
450-450: The ruff version upgrade to 0.14.11 is valid—it's the latest stable version released on January 8, 2026. No further action needed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
terryluan12
pushed a commit
to terryluan12/RustPython
that referenced
this pull request
Jan 15, 2026
* Update ruff to 0.14.11 in the CI
* Auto-format: cargo fmt --all
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|