GeezerVison is showing github.com — Add _asyncio and add test_asyncio by youknowone · Pull Request #6838 · RustPython/RustPython
Conversation
youknowone
commented
Jan 23, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
- Chores
- Updated spell check configuration to recognize additional CPython-related terminology.
- Modified CI pipeline to skip asyncio-related tests on Windows platform.
✏️ Tip: You can customize this high-level summary in your review settings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Jan 23, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
📝 Walkthrough
Walkthrough
This pull request adds three new CPython-related terms to the spell checker allowlist and includes an additional test in the Windows skip list for continuous integration workflows.
Changes
| Cohort / File(s) |
Summary |
Spell Checker Configuration .cspell.json |
Added three new CPython-related vocabulary entries ("sysdict", "settraceallthreads", "setprofileallthreads") to the words allowlist to prevent spelling check failures for internal CPython terms. |
CI Workflow Configuration .github/workflows/ci.yaml |
Added test_asyncio to the WINDOWS_SKIPS list, expanding the set of tests excluded from Windows CI runs. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
🐰 Hop along with words so new,
CPython terms now spelled just true,
And tests take breaks on Windows days,
Our configurations pave the ways! ✨
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name |
Status |
Explanation |
Resolution |
| Title check |
⚠️ Warning |
The pull request title 'Add _asyncio and add test_asyncio' is partially related to the changeset. While test_asyncio is mentioned (matching the Windows skip list change), the title suggests adding _asyncio module, but the actual changes only involve cspell configuration updates and a test skip list modification. The title does not accurately represent the main content of the changeset. |
Revise the title to more accurately reflect the actual changes, such as 'Add CPython vocabulary to cspell config and skip test_asyncio on Windows' or provide context explaining why the title references _asyncio when the changes don't include module additions. |
✅ Passed checks (2 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage |
✅ Passed |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Code has been automatically formatted
The code in this PR has been formatted using:
ruff format
Please pull the latest changes before pushing again:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
📦 Library Dependencies
The following Lib/ modules were modified. Here are their dependencies:
[ ] lib: cpython/Lib/asyncio
[ ] test: cpython/Lib/test/test_asyncio (TODO: 16)
dependencies:
- asyncio (native: _overlapped, _pyrepl.console, _remote_debugging, _winapi, asyncio.tools, collections.abc, concurrent.futures, errno, itertools, math, msvcrt, sys, time)
- ast (native: _ast, sys)
- collections (native: _weakref, itertools, sys)
- dataclasses (native: itertools, sys)
- enum (native: builtins, sys)
- io (native: _io, _thread, errno, sys)
- logging (native: atexit, errno, logging.handlers, sys, time)
- os (native: os.path, sys)
- site (native: _io, builtins, errno, sys)
- socket (native: _socket, sys)
- subprocess (native: builtins, errno, sys, time)
- tempfile (native: _thread, errno, sys)
- traceback (native: collections.abc, itertools, sys)
- weakref (native: _weakref, itertools, sys)
- _colorize, argparse, contextlib, contextvars, functools, heapq, inspect, linecache, reprlib, selectors, signal, stat, struct, threading, types, warnings
dependent tests: (8 tests)
- asyncio: test_asyncio test_builtin test_contextlib_async test_inspect test_logging test_os test_sys_settrace test_unittest
[x] lib: cpython/Lib/contextlib.py
[ ] test: cpython/Lib/test/test_contextlib.py (TODO: 5)
[ ] test: cpython/Lib/test/test_contextlib_async.py (TODO: 4)
dependencies:
dependent tests: (59 tests)
- contextlib: test__colorize test_android test_argparse test_asyncgen test_asyncio test_bdb test_buffer test_builtin test_calendar test_call test_cmd_line_script test_code_module test_codecs test_compileall test_concurrent_futures test_contextlib test_contextlib_async test_ctypes test_dbm_dumb test_dbm_sqlite3 test_descr test_dis test_doctest test_email test_ensurepip test_faulthandler test_functools test_genericalias test_httpservers test_importlib test_ipaddress test_ordered_dict test_os test_posix test_pprint test_regrtest test_resource test_runpy test_shutil test_socket test_socketserver test_sqlite3 test_ssl test_support test_tarfile test_tempfile test_typing test_unittest test_urllib2net test_urllibnet test_uuid test_venv test_weakref test_weakset test_with test_xml_etree test_xmlrpc test_zipfile test_zoneinfo
[ ] lib: cpython/Lib/os.py
[ ] test: cpython/Lib/test/test_os.py (TODO: 17)
dependencies:
dependent tests: (155 tests)
- os: test___all__ test__osx_support test_argparse test_ast test_asyncio test_atexit test_base64 test_baseexception test_bdb test_bool test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_cmd_line test_cmd_line_script test_compile test_compileall test_concurrent_futures test_configparser test_contextlib test_ctypes test_dbm test_dbm_dumb test_dbm_sqlite3 test_decimal test_devpoll test_doctest test_dtrace test_eintr test_email test_ensurepip test_enum test_epoll test_exception_hierarchy test_exceptions test_faulthandler test_fcntl test_file test_file_eintr test_filecmp test_fileinput test_fileio test_float test_fnmatch test_fractions test_fstring test_ftplib test_future_stmt test_genericalias test_genericpath test_getpass test_gettext test_glob test_graphlib test_gzip test_hash test_hashlib test_http_cookiejar test_httplib test_httpservers test_importlib test_inspect test_io test_ioctl test_json test_kqueue test_largefile test_linecache test_locale test_logging test_lzma test_mailbox test_marshal test_math test_mimetypes test_mmap test_msvcrt test_multiprocessing_fork test_multiprocessing_forkserver test_multiprocessing_main_handling test_multiprocessing_spawn test_ntpath test_openpty test_optparse test_os test_pathlib test_pkg test_pkgutil test_platform test_plistlib test_poll test_popen test_posix test_posixpath test_pty test_py_compile test_pyexpat test_random test_regrtest test_repl test_reprlib test_robotparser test_runpy test_script_helper test_selectors test_shelve test_shutil test_signal test_site test_smtpnet test_socket test_socketserver test_sqlite3 test_ssl test_stat test_string_literals test_structseq test_subprocess test_support test_sys test_sysconfig test_tabnanny test_tarfile test_tempfile test_thread test_threading test_tokenize test_tools test_trace test_tty test_typing test_unicode_file test_unicode_file_functions test_unittest test_univnewlines test_urllib test_urllib2 test_urllib2_localnet test_urllib2net test_urllibnet test_uuid test_venv test_wait3 test_wait4 test_webbrowser test_winapi test_winreg test_wsgiref test_xml_etree test_zipfile test_zipimport test_zoneinfo test_zstd
Legend:
[+] path exists in CPython
[x] up-to-date, [ ] outdated
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
youknowone
changed the title
Add _asyncio and update asyncio from 3.14.2
Add _asyncio and add test_asyncio
Jan 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|