GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix test_asyncio for windows by youknowone · Pull Request #6959 · RustPython/RustPython

Conversation

@youknowone

@youknowone youknowone commented Feb 2, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests

    • Expanded test coverage on Windows platform by enabling previously skipped tests.

  • Bug Fixes

    • Improved exception handler cleanup logic to properly manage named exception variables during unwinding, enhancing error handling reliability.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
youknowone added 2 commits February 2, 2026 13:02
@youknowone
fix asyncio
830dcf3
@youknowone
remove test_asyncio from windows_skip
13e3527
@coderabbitai

coderabbitai Bot commented Feb 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request makes two distinct changes: removing test_asyncio from the Windows test skip list in CI configuration, and augmenting exception handler cleanup block generation in the codegen compiler to carry exception name data for named exception handlers.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml		 Removed test_asyncio from Windows-specific test skip list (WINDOWS_SKIPS), expanding the set of tests run on Windows platform.
Exception Handler Cleanup
crates/codegen/src/compile.rs		 Replaced two push_fblock calls with push_fblock_full for HandlerCleanup fblocks, adding FBlockDatum parameter to carry exception name context. Passes FBlockDatum::ExceptionName(name) for named handlers and FBlockDatum::None for unnamed handlers.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly Related PRs

  • Fix asyncio compile #6739: Modifies exception-unwind handling in compile.rs with changes to fblock/unwind routing logic.
  • Add _asyncio and add test_asyncio  #6838: Directly related CI change involving the same WINDOWS_SKIPS entry for test_asyncio.
  • Rework exception compiler #6909: Modifies exception handling by switching to push_fblock_full and passing FBlockDatum for cleanup fblocks.

Poem

🐰 A rabbit hops through cleanup blocks,
Exception names in data locks,
Windows tests now run with glee,
No more skips on asyncio spree!
Handlers whisper secrets clear, ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix test_asyncio for windows' aligns with the main change shown in the raw summary: removing test_asyncio from WINDOWS_SKIPS in .github/workflows/ci.yaml to fix its execution on Windows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions
Auto-format: cargo fmt --all
89943fa
@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin asyncio
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone marked this pull request as ready for review February 2, 2026 06:43
@youknowone
youknowone merged commit f7b2660 into RustPython:main Feb 2, 2026
12 of 13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@youknowone
youknowone deleted the asyncio branch February 2, 2026 06:58
youknowone added a commit that referenced this pull request Sep 16, 2026
@youknowone
Fix test_asyncio for windows (#6959)
8273bf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.