GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix miri ci by ShaharNaveh · Pull Request #7093 · RustPython/RustPython

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Feb 12, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

makes #7092 to fail
rust-lang/miri#4855

Summary by CodeRabbit

  • Chores
    • Updated CI/CD configuration for build testing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ShaharNaveh
fix miri ci
475f075
@coderabbitai

coderabbitai Bot commented Feb 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The CI workflow's miri job NIGHTLY_CHANNEL environment variable was updated from "nightly" to "nightly-2026-02-11", pinning the Rust nightly toolchain to a specific date while preserving the associated comment.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yaml		 Updated NIGHTLY_CHANNEL environment variable in miri job from "nightly" to "nightly-2026-02-11" to pin a specific nightly toolchain date.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Unpin Rust nightly in CI #6022: Main PR that pins the miri job's NIGHTLY_CHANNEL to the specific date nightly-2026-02-11, directly reversing/adjusting an earlier change.
  • Pin rustc nightly to nightly-2025-07-18 for miri tests #5999: Also modifies the CI workflow's miri job to pin the Rust nightly toolchain to a specific date, addressing similar toolchain stability concerns.

Suggested reviewers

  • youknowone

Poem

🐰 A toolchain pinned with care,
Nightly dates fixed in the air,
CI stable, miri won't drift,
A temporal gift! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix miri ci' is vague and lacks specificity about what aspect of the miri CI was fixed or what the actual change entails. Provide a more descriptive title that specifies the nature of the fix, such as 'Update NIGHTLY_CHANNEL environment variable in miri CI job' or 'Fix miri CI by updating nightly channel reference'
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
youknowone
youknowone approved these changes Feb 12, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
youknowone enabled auto-merge (squash) February 12, 2026 15:08
@youknowone
youknowone disabled auto-merge February 12, 2026 15:17
@youknowone
youknowone merged commit 8459e9b into RustPython:main Feb 12, 2026
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai coderabbitai Bot mentioned this pull request Mar 7, 2026
Unpin nightly channel for miri tests #7378
Merged
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
@ShaharNaveh
fix miri ci (RustPython#7093)
77eef9f
@coderabbitai coderabbitai Bot mentioned this pull request Mar 30, 2026
[zizmor] ignore superfluous-actions #7548
Merged
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
fix miri ci (#7093)
9459966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ShaharNaveh @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.