GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Replace PyFunction.code PyMutex with PyAtomicRef for lock-free reads by youknowone · Pull Request #7317 · RustPython/RustPython

Conversation

youknowone commented Mar 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Change the code field from PyMutex<PyRef> to PyAtomicRef, eliminating mutex lock/unlock on every function call. The setter uses swap_to_temporary_refs for safe deferred drop of the old code object.

Summary by CodeRabbit

Refactor
- Optimized internal code handling mechanisms in the function execution system.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Replace PyFunction.code PyMutex with PyAtomicRef for lock-free reads

5defc42

Change the code field from PyMutex<PyRef<PyCode>> to PyAtomicRef<PyCode>,
eliminating mutex lock/unlock on every function call. The setter uses
swap_to_temporary_refs for safe deferred drop of the old code object.

coderabbitai Bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

📝 Walkthrough

Walkthrough

The pull request refactors PyFunction's code field from a mutex-protected reference to an atomic reference, eliminating lock-based access patterns across getters, setters, and JIT paths while maintaining thread-safe semantics.

Changes

Cohort / File(s) Summary

Core PyFunction Implementation
crates/vm/src/builtins/function.rs Replaced PyMutex<PyRef<PyCode>> field with PyAtomicRef<PyCode>, updated initialization to use PyAtomicRef::from(), modified __code__ getter to return (*self.code).to_owned(), added VirtualMachine parameter to set___code__ method, and converted all code access from lock-based retrieval to direct atomic dereferencing across can_specialize_call, invoke_with_locals, invoke_exact_args, and error messaging paths.

JIT Code Access Patterns
crates/vm/src/builtins/function/jit.rs Replaced func.code.lock() calls with direct reference let code: &Py<PyCode> = &func.code in get_jit_arg_types and get_jit_args, removed explicit drop(code), and updated all code introspection operations to use direct atomic reference semantics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Fix PyCode constructor/replace #6193: Directly modifies PyFunction.code field storage mechanism with complementary synchronization strategy changes.
SetFunctionAttribute #5968: Related through overlapping PyFunction implementation modifications including field handling and initialization paths.

Suggested reviewers

ShaharNaveh

Poem

🐰✨ From mutex locks to atoms so bright,
The code now flows without holding tight,
No lock() calls, just references free,
Swift and lean, as refs should be!
A hoppy refactor, atomic and light! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'Replace PyFunction.code PyMutex with PyAtomicRef for lock-free reads' accurately summarizes the main change: replacing a mutex-backed reference type with an atomic reference type to enable lock-free reads.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone marked this pull request as ready for review

March 3, 2026 00:05

coderabbitai Bot reviewed

Mar 3, 2026

View reviewed changes

coderabbitai Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/vm/src/builtins/function.rs`:
- Around line 682-684: When assigning a new code object in set___code__, also
invalidate any cached JIT artifacts so the old machine code cannot be used;
specifically, after self.code.swap_to_temporary_refs(...) and before/after
self.func_version.store(0, Relaxed), clear the cached jitted_code (and any
associated owner/version fields used by the JIT fast path) so invoke_with_locals
cannot find/execute stale compiled code — update the fields that hold the
compiled entry (jitted_code) to a neutral/empty state consistent with how they
are checked in invoke_with_locals.

ℹ️ Review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a6a6f8 and 5defc42.

📒 Files selected for processing (2)

crates/vm/src/builtins/function.rs
crates/vm/src/builtins/function/jit.rs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

crates/vm/src/builtins/function.rs

Comment on lines +682 to 684

		fn set___code__(&self, code: PyRef<PyCode>, vm: &VirtualMachine) {
		self.code.swap_to_temporary_refs(code, vm);
		self.func_version.store(0, Relaxed);

coderabbitai Bot Mar 3, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Invalidate cached JIT code when __code__ is reassigned.

Line 683 swaps the code object, but the cached jitted_code is not reset. The JIT fast path in invoke_with_locals (Line 533 onward) still executes cached compiled code when present, so f.__code__ = ... can leave the function running stale machine code.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/vm/src/builtins/function.rs` around lines 682 - 684, When assigning a
new code object in set___code__, also invalidate any cached JIT artifacts so the
old machine code cannot be used; specifically, after
self.code.swap_to_temporary_refs(...) and before/after
self.func_version.store(0, Relaxed), clear the cached jitted_code (and any
associated owner/version fields used by the JIT fast path) so invoke_with_locals
cannot find/execute stale compiled code — update the fields that hold the
compiled entry (jitted_code) to a neutral/empty state consistent with how they
are checked in invoke_with_locals.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

youknowone merged commit 43e2df3 into RustPython:main

Mar 3, 2026

13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

youknowone deleted the func-code-lockfree branch

March 3, 2026 00:18

coderabbitai Bot mentioned this pull request

Mar 4, 2026

Align specialization guards and caching with CPython #7341

Merged

youknowone added a commit to youknowone/RustPython that referenced this pull request

Mar 22, 2026


          Replace PyFunction.code PyMutex with PyAtomicRef for lock-free reads (R…

9cdd092

…ustPython#7317)

Change the code field from PyMutex<PyRef<PyCode>> to PyAtomicRef<PyCode>,
eliminating mutex lock/unlock on every function call. The setter uses
swap_to_temporary_refs for safe deferred drop of the old code object.

youknowone added a commit that referenced this pull request

Sep 16, 2026


          Replace PyFunction.code PyMutex with PyAtomicRef for lock-free reads (#…

454f7db

…7317)

Change the code field from PyMutex<PyRef<PyCode>> to PyAtomicRef<PyCode>,
eliminating mutex lock/unlock on every function call. The setter uses
swap_to_temporary_refs for safe deferred drop of the old code object.

Reviewers

coderabbitai[bot]

coderabbitai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

youknowone commented Mar 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

youknowone commented Mar 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.