GeezerVison

crates/codegen/src/compile.rs (1)

4344-4400: Collapse the repeated SetFunctionAttribute branches into an ordered loop.

These branches only vary by MakeFunctionFlag and duplicate the same emission logic. A small ordered list keeps the application order explicit and makes future flag additions easier to maintain.

♻️ Proposed refactor

         if has_freevars {
             emit!(
                 self,
                 Instruction::SetFunctionAttribute {
                     flag: bytecode::MakeFunctionFlag::Closure
                 }
             );
         }

-        // Set annotations if present
-        if flags.contains(&bytecode::MakeFunctionFlag::Annotations) {
-            emit!(
-                self,
-                Instruction::SetFunctionAttribute {
-                    flag: bytecode::MakeFunctionFlag::Annotations
-                }
-            );
-        }
-
-        // Set __annotate__ closure if present (PEP 649)
-        if flags.contains(&bytecode::MakeFunctionFlag::Annotate) {
-            emit!(
-                self,
-                Instruction::SetFunctionAttribute {
-                    flag: bytecode::MakeFunctionFlag::Annotate
-                }
-            );
-        }
-
-        // Set kwdefaults if present
-        if flags.contains(&bytecode::MakeFunctionFlag::KwOnlyDefaults) {
-            emit!(
-                self,
-                Instruction::SetFunctionAttribute {
-                    flag: bytecode::MakeFunctionFlag::KwOnlyDefaults
-                }
-            );
-        }
-
-        // Set defaults if present
-        if flags.contains(&bytecode::MakeFunctionFlag::Defaults) {
-            emit!(
-                self,
-                Instruction::SetFunctionAttribute {
-                    flag: bytecode::MakeFunctionFlag::Defaults
-                }
-            );
-        }
-
-        // Set type_params if present
-        if flags.contains(&bytecode::MakeFunctionFlag::TypeParams) {
-            emit!(
-                self,
-                Instruction::SetFunctionAttribute {
-                    flag: bytecode::MakeFunctionFlag::TypeParams
-                }
-            );
-        }
+        for flag in [
+            bytecode::MakeFunctionFlag::Annotations,
+            bytecode::MakeFunctionFlag::Annotate,
+            bytecode::MakeFunctionFlag::KwOnlyDefaults,
+            bytecode::MakeFunctionFlag::Defaults,
+            bytecode::MakeFunctionFlag::TypeParams,
+        ] {
+            if flags.contains(&flag) {
+                emit!(self, Instruction::SetFunctionAttribute { flag });
+            }
+        }

As per coding guidelines: "When branches differ only in a value but share common logic, extract the differing value first, then call the common logic once to avoid duplicate code"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/codegen/src/compile.rs` around lines 4344 - 4400, The repeated
branches setting SetFunctionAttribute for each MakeFunctionFlag should be
replaced with a single ordered iteration: create an ordered array of the flags
(e.g., bytecode::MakeFunctionFlag::Closure, ::Annotations, ::Annotate,
::KwOnlyDefaults, ::Defaults, ::TypeParams), then loop over that array and for
each flag call if flags.contains(&flag) { emit!(self,
Instruction::SetFunctionAttribute { flag }) }; this preserves the explicit
order, removes duplicated emit logic, and keeps the behavior of
SetFunctionAttribute in one place.