GeezerVison is showing github.com — Move dependencies to workspace for `common` crate by fanninpm · Pull Request #7771 · RustPython/RustPython
Conversation
fanninpm
commented
May 4, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
cc @ShaharNaveh
Summary by CodeRabbit
- Chores
- Centralized workspace dependency management to improve build consistency and simplify version control across the project.
- Added and aligned new workspace-managed dependency entries to ensure consistent builds across crates.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
May 4, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: f4077671-3a00-40ff-b158-adbc2a1e1139
📥 Commits
Reviewing files that changed from the base of the PR and between 1e9bc0d and 0ee5db4.
📒 Files selected for processing (2)
Cargo.tomlcrates/common/Cargo.toml
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough
Walkthrough
This PR adds lock_api and siphasher to the root Cargo.toml [workspace.dependencies] and updates crates/common/Cargo.toml to reference lock_api, siphasher, and num-complex via { workspace = true } instead of inline version pins. No public Rust APIs changed.
Changes
Workspace Dependency Consolidation
| Layer / File(s) |
Summary |
Workspace Dependency Definitions
Cargo.toml |
Inserted lock_api = "0.4" and siphasher = "1" into [workspace.dependencies]. |
Crate Dependency Wiring
crates/common/Cargo.toml |
Switched lock_api, siphasher, and num-complex dependency entries to workspace-managed form: { workspace = true }. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
🐰
I hopped through manifests in the night,
Added locks and sips with gentle bite,
Workspace one keeps versions tight,
Dependencies snug — a coder's delight!
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
✅ Passed |
The title accurately and concisely describes the main change: moving dependencies from the common crate to the workspace, which aligns with both commit messages and the changeset modifications. |
| Docstring Coverage |
✅ Passed |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check |
✅ Passed |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check |
✅ Passed |
Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced May 13, 2026
youknowone
pushed a commit
that referenced
this pull request
Sep 16, 2026
* Add dependencies from `common` crate to workspace
* Declare dependencies as workspace = true
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.