GeezerVison

crates/capi/src/abstract_/mapping.rs (1)

10-38: 💤 Low value

Consider extracting shared logic into a helper to reduce duplication.

All three functions follow the same pattern: get mapping, call method, iterate to list. Per coding guidelines, when branches differ only in a method call but share common logic, extracting the common parts improves maintainability.

♻️ Possible helper extraction

+fn mapping_to_list(
+    obj: *mut PyObject,
+    get_items: impl FnOnce(&rustpython_vm::protocol::PyMapping, &rustpython_vm::VirtualMachine) -> rustpython_vm::PyResult<rustpython_vm::PyObjectRef>,
+) -> *mut PyObject {
+    with_vm(|vm| {
+        let obj = unsafe { &*obj };
+        let items = get_items(&obj.try_mapping(vm)?, vm)?;
+        let iter = items.get_iter(vm)?;
+        Ok(vm.ctx.new_list(iter.try_to_value(vm)?))
+    })
+}
+
 #[unsafe(no_mangle)]
 pub unsafe extern "C" fn PyMapping_Keys(obj: *mut PyObject) -> *mut PyObject {
-    with_vm(|vm| {
-        let obj = unsafe { &*obj };
-        let keys = obj.try_mapping(vm)?.keys(vm)?;
-        let iter = keys.get_iter(vm)?;
-        Ok(vm.ctx.new_list(iter.try_to_value(vm)?))
-    })
+    mapping_to_list(obj, |m, vm| m.keys(vm))
 }

Apply similarly to PyMapping_Values and PyMapping_Items.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/capi/src/abstract_/mapping.rs` around lines 10 - 38, Extract the
repeated logic in PyMapping_Keys, PyMapping_Values, and PyMapping_Items into a
small helper (e.g., fn map_to_list(obj: *mut PyObject, f: impl FnOnce(&dyn
Mapping, &VirtualMachine) -> PyResult<PyObjectRef>) -> *mut PyObject or a helper
taking an enum/closure) that: calls with_vm, dereferences obj, calls
obj.try_mapping(vm)?, invokes the specific mapping method (keys/values/items)
via the passed closure or selector, gets the iterator via get_iter(vm)?,
converts it with try_to_value(vm) and returns vm.ctx.new_list(...); then replace
the bodies of PyMapping_Keys, PyMapping_Values and PyMapping_Items to call this
helper with the appropriate mapping method selector so the only differing part
is the method passed in.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes