GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more int functions to the c-api by bschoenmaeckers · Pull Request #8159 · RustPython/RustPython

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Jun 24, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Expanded integer C API support with new PyLong_From* constructors for doubles, signed/unsigned 32- and 64-bit values, native-endian byte buffers, C strings (optional end-pointer), and void*/pointer-sized values.
    • Added a wider set of PyLong_As* conversions (typed signed/unsigned, size types, and mask variants), replacing PyLong_AsLong.
  • Bug Fixes
    • Improved unsigned mask extraction for negative integers using low-order digits.
  • Tests
    • Extended C/API conversion coverage for sentinel/error-value behavior and added large-integer roundtrip assertions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coderabbitai

coderabbitai Bot commented Jun 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9be578bf-0880-4423-b33e-377d1db93471

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad78c4 and 18f4929.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .cspell.dict/cpython.txt
  • crates/capi/Cargo.toml
  • crates/capi/src/longobject.rs
🚧 Files skipped from review as they are similar to previous changes (2)
  • crates/capi/Cargo.toml
  • crates/capi/src/longobject.rs
📝 Walkthrough

Walkthrough

Expanded the PyLong C-API with new constructors and extractors, extended integer FfiResult outputs, and changed PyInt unsigned mask handling.

Changes

PyLong C-API expansion

Layer / File(s) Summary
Add PyLong constructors
crates/capi/Cargo.toml, crates/capi/src/longobject.rs, .cspell.dict/cpython.txt		 Adds constructors from floating-point, fixed-width integers, pointers, native-byte buffers, and C strings, with native-byte flag parsing support and a new bigint dependency.
Add PyLong numeric extractors
crates/capi/src/longobject.rs		 Adds floating-point, signed, unsigned, out-parameter, and pointer extraction APIs, plus the updated unsigned-long-long conversion path and disabled u128 round-trip test.
Extend FfiResult for integer outputs
crates/capi/src/util.rs		 Adds direct-output FfiResult implementations for additional C integer types and adds sentinel-value tests for the new instantiations.
Fix u32/u64 digit masking in PyInt
crates/vm/src/builtins/int.rs		 Changes as_u32_mask and as_u64_mask to derive masked values from leading digits and apply wrapping_neg() for negative values.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related issues

  • C-API tracking: missing Stable ABI functions in crates/capi #8156: Adds several PyLong_* C-API exports that match missing Stable ABI Include/longobject.h entries.

Possibly related PRs

  • RustPython/RustPython#7787: Extends the same FfiResult trait and integer conversion support in crates/capi/src/util.rs.
  • RustPython/RustPython#7905: Modifies the same PyLong_* C-API conversion area in crates/capi/src/longobject.rs.
  • RustPython/RustPython#8170: Also adjusts crates/capi/src/util.rs integer sentinel behavior used by C-API conversions.

Suggested reviewers

  • youknowone
  • ShaharNaveh

Poem

🐇 I hopped through ints both small and wide,
and pointer paws now fit just right.
Masked bits twinkle, neat and clear,
while bigint moons stay round and near.
Hoppity hop, the C-API sings!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 72.09% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: expanding the C-API with more integer-related functions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch 5 times, most recently from 6aa3a82 to 3d85bb2 Compare June 25, 2026 11:30
@bschoenmaeckers

bschoenmaeckers commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai resume
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Reviews resumed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch from 3d85bb2 to 2a94827 Compare June 25, 2026 11:33
youknowone
youknowone reviewed Jun 25, 2026
View reviewed changes
Comment thread crates/vm/src/builtins/int.rs Outdated
#[must_use]
pub fn as_u64_mask(&self) -> u64 {
let v = self.as_bigint();
v.to_u64()

@youknowone youknowone Jun 25, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't investigate the detail yet, but trying to_u64 looks like redundant operation if the fallback still use the last digits

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bschoenmaeckers bschoenmaeckers Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Looking at the simplified logic this feels redundant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bschoenmaeckers bschoenmaeckers Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also applied this to the u32 function

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch from acec52f to b8835a8 Compare June 25, 2026 15:23
coderabbitai[bot]
coderabbitai Bot reviewed Jun 26, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/capi/src/longobject.rs`:
- Around line 92-106: The flag parsing in
AsNativeBytesFlags::from_bits_or_default currently accepts the reserved endian
value 2 because it passes through AsNativeBytesFlags::from_bits; add an explicit
rejection for that raw flag before the generic bitmask check so
PyLong_FromNativeBytes and PyLong_FromUnsignedNativeBytes raise ValueError for 2
while still preserving the existing default behavior for -1. Keep the Default
implementation unchanged, since Self::NATIVE_ENDIAN | Self::UNSIGNED_BUFFER is
correct, and ensure the new validation is localized to from_bits_or_default so
both call sites inherit it automatically.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: e0d68fea-f4dd-4ac0-9ab6-740c9eee9e6b

📥 Commits

Reviewing files that changed from the base of the PR and between b8835a8 and 4cf4334.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/capi/Cargo.toml
  • crates/capi/src/longobject.rs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread crates/capi/src/longobject.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch from 4cf4334 to ad92c2c Compare June 26, 2026 07:29
@bschoenmaeckers

bschoenmaeckers commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai resume
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Reviews resumed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch 2 times, most recently from 2bffd0c to 18e54a6 Compare June 26, 2026 07:40
bschoenmaeckers added 2 commits June 29, 2026 13:04
@bschoenmaeckers
Add more int functions to the c-api
8c3e70c
@bschoenmaeckers
Simplify as_mask logic
6f72de6
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch from 18e54a6 to 4ad78c4 Compare June 29, 2026 11:04
@bschoenmaeckers
Add PyLong_FromNativeBytes & PyLong_FromUnsignedNativeBytes
18f4929
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-more-long branch from 4ad78c4 to 18f4929 Compare June 29, 2026 11:59
youknowone
youknowone approved these changes Jun 30, 2026
View reviewed changes
@youknowone
youknowone merged commit 33b8c10 into RustPython:main Jun 30, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bschoenmaeckers
bschoenmaeckers deleted the c-api-more-long branch June 30, 2026 15:12
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@bschoenmaeckers
Add more int functions to the c-api (#8159)
d1792fd 
* Add more int functions to the c-api

* Simplify as_mask logic

* Add `PyLong_FromNativeBytes` & `PyLong_FromUnsignedNativeBytes`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bschoenmaeckers @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.