GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more mapping functions to c-api by bschoenmaeckers · Pull Request #8169 · RustPython/RustPython

Add more mapping functions to c-api #8169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into RustPython:main from bschoenmaeckers:c-api-more-mapping
Jun 25, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

Add more mapping functions to c-api #8169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
94cee7f
Add more mapping functions to c-api
bschoenmaeckers Jun 25, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

157 changes: 157 additions & 0 deletions 157 crates/capi/src/abstract_/mapping.rs
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
use crate::{PyObject, pystate::with_vm};
use core::ffi::{CStr, c_char, c_int};
use rustpython_vm::AsObject;

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_Check(obj: *mut PyObject) -> c_int {
with_vm(|_vm| {
let obj = unsafe { &*obj };
Ok(obj.mapping_unchecked().check())
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_Size(obj: *mut PyObject) -> isize {
with_vm(|vm| {
Expand All @@ -7,6 +18,11 @@ pub unsafe extern "C" fn PyMapping_Size(obj: *mut PyObject) -> isize {
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_Length(obj: *mut PyObject) -> isize {
unsafe { PyMapping_Size(obj) }
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_Keys(obj: *mut PyObject) -> *mut PyObject {
with_vm(|vm| {
Expand Down Expand Up @@ -37,6 +53,147 @@ pub unsafe extern "C" fn PyMapping_Items(obj: *mut PyObject) -> *mut PyObject {
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_GetItemString(
obj: *mut PyObject,
key: *const c_char,
) -> *mut PyObject {
with_vm(|vm| {
let obj = unsafe { &*obj };
let key = unsafe { CStr::from_ptr(key) }
.to_str()
.map_err(|_| vm.new_value_error("mapping key must be valid UTF-8"))?;
obj.get_item(key, vm)
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_GetOptionalItem(
obj: *mut PyObject,
key: *mut PyObject,
result: *mut *mut PyObject,
) -> c_int {
with_vm(|vm| {
unsafe {
*result = core::ptr::null_mut();
}
let obj = unsafe { &*obj };
let key = unsafe { &*key };

match obj.get_item(key, vm) {
Ok(value) => {
unsafe {
*result = value.into_raw().as_ptr();
}
Ok(true)
}
Err(err) if err.fast_isinstance(vm.ctx.exceptions.key_error) => Ok(false),
Err(err) => Err(err),
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_GetOptionalItemString(
obj: *mut PyObject,
key: *const c_char,
result: *mut *mut PyObject,
) -> c_int {
with_vm(|vm| {
unsafe {
*result = core::ptr::null_mut();
}
let obj = unsafe { &*obj };
let key = unsafe { CStr::from_ptr(key) }
.to_str()
.map_err(|_| vm.new_value_error("mapping key must be valid UTF-8"))?;

match obj.get_item(key, vm) {
Ok(value) => {
unsafe {
*result = value.into_raw().as_ptr();
}
Ok(true)
}
Err(err) if err.fast_isinstance(vm.ctx.exceptions.key_error) => Ok(false),
Err(err) => Err(err),
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_HasKey(obj: *mut PyObject, key: *mut PyObject) -> c_int {
with_vm(|vm| {
let obj = unsafe { &*obj };
let key = unsafe { &*key };
obj.get_item(key, vm).is_ok()
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_HasKeyString(obj: *mut PyObject, key: *const c_char) -> c_int {
with_vm(|vm| {
let obj = unsafe { &*obj };
if let Ok(key) = unsafe { CStr::from_ptr(key) }.to_str() {
obj.get_item(key, vm).is_ok()
} else {
false
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_HasKeyWithError(
obj: *mut PyObject,
key: *mut PyObject,
) -> c_int {
with_vm(|vm| {
let obj = unsafe { &*obj };
let key = unsafe { &*key };

match obj.get_item(key, vm) {
Ok(_) => Ok(true),
Err(err) if err.fast_isinstance(vm.ctx.exceptions.key_error) => Ok(false),
Err(err) => Err(err),
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_HasKeyStringWithError(
obj: *mut PyObject,
key: *const c_char,
) -> c_int {
with_vm(|vm| {
let obj = unsafe { &*obj };
let key = unsafe { CStr::from_ptr(key) }
.to_str()
.map_err(|_| vm.new_value_error("mapping key must be valid UTF-8"))?;

match obj.get_item(key, vm) {
Ok(_) => Ok(true),
Err(err) if err.fast_isinstance(vm.ctx.exceptions.key_error) => Ok(false),
Err(err) => Err(err),
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyMapping_SetItemString(
obj: *mut PyObject,
key: *const c_char,
value: *mut PyObject,
) -> c_int {
with_vm(|vm| {
let obj = unsafe { &*obj };
let key = unsafe { CStr::from_ptr(key) }
.to_str()
.map_err(|_| vm.new_value_error("mapping key must be valid UTF-8"))?;
let value = unsafe { &*value }.to_owned();
obj.set_item(key, value, vm)
})
}

#[cfg(false)]
mod tests {
use pyo3::prelude::*;
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.