GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set python args to be like CPython in CI by ShaharNaveh · Pull Request #8181 · RustPython/RustPython

Set python args to be like CPython in CI #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into RustPython:main from ShaharNaveh:ci-cpython-like-args
Jul 6, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

Set python args to be like CPython in CI #8181

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd809ce
Set python args to be like CPython in CI (ish)
ShaharNaveh Jun 26, 2026
128cee9
Use `--slow-ci`
ShaharNaveh Jun 27, 2026
74aca0c
`--dont-add-python-opts`
ShaharNaveh Jun 27, 2026
7b47348
unmark passing test
ShaharNaveh Jun 27, 2026
674bfa3
Merge remote-tracking branch 'upstream/main' into ci-cpython-like-args
ShaharNaveh Jul 1, 2026
File filter
Filter by extension


Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Diff view
Diff view
Prev Previous commit
Next Next commit
--dont-add-python-opts
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@ShaharNaveh
ShaharNaveh committed Jun 27, 2026
commit 74aca0cdfa806cff54170857b2eb262fbc30e005

There are no files selected for viewing

5 changes: 4 additions & 1 deletion 5 .github/workflows/ci.yaml
Show comments Show annotations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
extra_test_args:
- '-u all'
- '--timeout 600'
Comment thread

@youknowone youknowone Jul 4, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if everything requires same args, dose it still need to be extra_test_args?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@ShaharNaveh ShaharNaveh Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's repeated multiple times, I think this is the easiest way to manage it for now.

we repeat this arg in 2/3 times that we run the test suite. I can "hardcode" it in all other places instead, not a big deal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@youknowone youknowone Jul 6, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra_test_args changes the test name. then merge queue settings also must be updated.
that's not a big deal when it occasionally changes. but it happens more than common these days. So i wish that's still an argument, but not being a part of job title.

also it makes the CI job name unnecessary longer, not a big deal itself too though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@ShaharNaveh ShaharNaveh Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra_test_args changes the test name. then merge queue settings also must be updated. that's not a big deal when it occasionally changes. but it happens more than common these days. So i wish that's still an argument, but not being a part of job title.

also it makes the CI job name unnecessary longer, not a big deal itself too though.

CPython uses an external file to manage their CI commands, we could do the same using just for example.

bevy wrote their own tool for that, we could do something similar.

I'm in favor of starting with the just approach (or similar), if you think it's a good idea.

There's another option which I'm less of a fan of, but still worth mentioning. cargo alias can also do that, but that's adding another layer without the full features that justgives us, i.e. reuse of variables. (we can't define a variable called common_args and use it everywhere).

lmk if that makes sense to you and/or worth implementing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@youknowone youknowone Jul 6, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way i am good as long as contributors still can copy the same CI command from web CI view to their terminal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ShaharNaveh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
- '--dont-add-python-opts'
env_polluting_tests:
- test_set
skips: []
Expand All @@ -304,6 +305,7 @@
extra_test_args:
- '-u all'
- '--timeout 600'
- '--dont-add-python-opts'
env_polluting_tests:
- test_set
skips: []
Expand All @@ -312,6 +314,7 @@
extra_test_args:
- '-u all'
- '--timeout 600'
- '--dont-add-python-opts'
env_polluting_tests:
- test_set
skips: []
Expand Down Expand Up @@ -360,7 +363,7 @@
run: |
cores=$(python -c 'print(__import__("os").process_cpu_count())')
echo "cores=${cores}" >> "$GITHUB_OUTPUT"

- name: Run CPython tests
run: |
target/release/rustpython -u -m test --slow-ci -j ${{ steps.cores.outputs.cores }} ${{ join(matrix.extra_test_args, ' ') }} -x ${{ env.FLAKY_MP_TESTS }} ${{ join(matrix.skips, ' ') }}
Comment thread
Expand Down Expand Up @@ -399,7 +402,7 @@
for thing in "${target_array[@]}"; do
for i in $(seq 1 10); do
set +e
target/release/rustpython -u -m test --slow-ci -u all -j 1 --timeout 600 "${thing}"
target/release/rustpython -u -m test --slow-ci -u all -j 1 --timeout 600 --dont-add-python-opts "${thing}"
exit_code=$?
set -e
if [ "${exit_code}" -eq 3 ]; then
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.