GeezerVison is showing github.com — Add memoryview support to c-api by bschoenmaeckers · Pull Request #8240 · RustPython/RustPython
Conversation
bschoenmaeckers
commented
Jul 8, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
-
New Features
- Added support for creating Python memory views from existing objects.
- Exposed a new memory view type check for use by the C-API layer.
-
Tests
- Added coverage to verify memory views can be created from bytes and return the original data correctly.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Jul 8, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: e471bd3c-748b-4176-b173-b089b5c52e71
📥 Commits
Reviewing files that changed from the base of the PR and between 6a118b3 and b5be40e.
📒 Files selected for processing (2)
crates/capi/src/lib.rscrates/capi/src/memoryobject.rs
📝 Walkthrough
Walkthrough
Adds a new memoryobject module to the capi crate, exposing the PyMemoryView_FromObject unsafe extern "C" function that converts a raw PyObject pointer into a PyMemoryView, along with a PyMemoryView_Check helper and an accompanying test.
Changes
Memoryview C-API
| Layer / File(s) |
Summary |
Module registration and PyMemoryView_FromObject implementation
crates/capi/src/lib.rs, crates/capi/src/memoryobject.rs |
Adds pub mod memoryobject; export and implements PyMemoryView_FromObject, which wraps object-to-memoryview conversion via with_vm, plus PyMemoryView_Check via define_py_check! and a test validating bytes-to-memoryview-to-bytes round-tripping. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers: youknowone, ShaharNaveh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name |
Status |
Explanation |
| Description Check |
✅ Passed |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
✅ Passed |
The title clearly matches the main change: adding memoryview support to the C API. |
| Docstring Coverage |
✅ Passed |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check |
✅ Passed |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check |
✅ Passed |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.