GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add AsyncIterator support to c-api by bschoenmaeckers · Pull Request #8285 · RustPython/RustPython

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Jul 14, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added C API support for detecting whether an object is an asynchronous iterator.
    • Added C API support for retrieving an object’s asynchronous iterator, complementing existing synchronous iterator functionality.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: eea2a874-9eb0-4bfc-8a45-967ed80ed4f8

📥 Commits

Reviewing files that changed from the base of the PR and between f816d07 and 4236d77.

📒 Files selected for processing (1)
  • crates/capi/src/abstract_/iter.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/capi/src/abstract_/iter.rs

📝 Walkthrough

Walkthrough

Adds C-ABI functions to check whether an object supports asynchronous iteration and to retrieve its asynchronous iterator through the active VM context.

Changes

Async iterator C API

Layer / File(s) Summary
Async iterator entry points
crates/capi/src/abstract_/iter.rs
Exports PyAIter_Check for __anext__ detection and PyObject_GetAIter for retrieving an object’s asynchronous iterator.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • RustPython/RustPython#8035: Adds corresponding synchronous iterator C-ABI entry points in the same module.

Suggested reviewers: youknowone

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding async iterator support to the C API.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bschoenmaeckers
Add AsyncIterator support to c-api
4236d77
@bschoenmaeckers
bschoenmaeckers force-pushed the c-api-async-iter branch from f816d07 to 4236d77 Compare July 14, 2026 15:29
youknowone
youknowone approved these changes Jul 15, 2026
View reviewed changes
@youknowone
youknowone merged commit 74b598e into RustPython:main Jul 15, 2026
49 of 50 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bschoenmaeckers
bschoenmaeckers deleted the c-api-async-iter branch July 15, 2026 14:46
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@bschoenmaeckers
Add AsyncIterator support to c-api (#8285)
96fde50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bschoenmaeckers @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.