GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove obsolete _symtable APIs by YangSiJun528 · Pull Request #8309 · RustPython/RustPython

Conversation

@YangSiJun528

@YangSiJun528 YangSiJun528 commented Jul 17, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • This PR follows our AI policy

Summary

  • Remove the unused native _symtable.Symbol implementation.
  • Remove the unused identifiers getter from symbol table entries.
  • Keep _symtable limited to the low-level interface consumed by Lib/symtable.py.

RustPython originally implemented the public symtable API in Rust. After #6048 added CPython's Lib/symtable.py, the public Symbol implementation moved to Python and the native PySymbol became unreachable.

CPython similarly implements the public symtable.Symbol class in Lib/symtable.py, rather than exposing it from _symtable.

Testing

  • cargo run --release -- -m test test_symtable
  • cargo test -p rustpython-vm
  • prek run --all-files

AI assistance

Codex (GPT‑5.6 Sol) was used to investigate and implement this change.
I reviewed and validated all AI-assisted work.

Summary by CodeRabbit

  • Breaking Changes
    • Removed the Symbol class from the symbol table API.
    • Removed the identifiers accessor from symbol table entries.
  • API Changes
    • Symbol table entries now expose symbol names and their flag values through the symbols mapping.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@YangSiJun528
Remove obsolete _symtable APIs
d486b22 
stdlib/_symtable.rs previously provided the public Symbol API. When
7f1fc36 imported Lib/symtable.py, responsibility for the public Symbol
implementation moved to Python, but the native implementation remained.

Remove it along with the unused identifiers getter.

Assisted-by: Codex:gpt-5.6-sol
@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 2d9040de-b10b-459c-a7bf-8f69708a49e6

📥 Commits

Reviewing files that changed from the base of the PR and between 1205fd2 and d486b22.

📒 Files selected for processing (1)
  • crates/vm/src/stdlib/_symtable.rs
📝 Walkthrough

Walkthrough

The symtable module removes the identifiers getter and the Python-exposed Symbol class, along with its symbol-property and namespace accessors. The unused Symbol import is also removed.

Changes

Symtable API reduction

Layer / File(s) Summary
Remove obsolete symtable APIs
crates/vm/src/stdlib/_symtable.rs		 Removes the unused Symbol import, the identifiers getter, and the PySymbol class with its symbol and namespace accessors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: shaharnaveh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing obsolete _symtable APIs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShaharNaveh
ShaharNaveh approved these changes Jul 17, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, tysm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
YangSiJun528 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@fanninpm
fanninpm requested a review from youknowone July 17, 2026 20:35
@moreal moreal added the z-ca-2026 Tag to track Contribution Academy 2026 label Jul 18, 2026
youknowone
youknowone approved these changes Jul 18, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@youknowone
youknowone merged commit 0bc109d into RustPython:main Jul 18, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai coderabbitai Bot mentioned this pull request Aug 16, 2026
Expose symbol scopes through _symtable #8538
Merged
1 task done
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@YangSiJun528
Remove obsolete _symtable APIs (#8309)
6854453 
stdlib/_symtable.rs previously provided the public Symbol API. When
7f1fc36 imported Lib/symtable.py, responsibility for the public Symbol
implementation moved to Python, but the native implementation remained.

Remove it along with the unused identifiers getter.

Assisted-by: Codex:gpt-5.6-sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

z-ca-2026 Tag to track Contribution Academy 2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@YangSiJun528 @youknowone @ShaharNaveh @moreal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.