GeezerVison

crates/vm/src/stdlib/time.rs (1)

571-578: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use a helper closure to deduplicate the ASCII buffer flush logic.

The logic for flushing ascii to out is duplicated three times. Consider extracting it into a closure to improve maintainability.

♻️ Proposed refactor

         let mut out = Wtf8Buf::new();
         let mut ascii = String::new();
 
+        let mut flush_ascii = |ascii: &mut String, out: &mut Wtf8Buf| -> PyResult<()> {
+            if !ascii.is_empty() {
+                let part =
+                    host_time::strftime_ascii(ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
+                out.extend(part.chars());
+                ascii.clear();
+            }
+            Ok(())
+        };
+
         for codepoint in format.as_wtf8().code_points() {
             if codepoint.to_u32() == 0 {
-                if !ascii.is_empty() {
-                    let part =
-                        host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-                    out.extend(part.chars());
-                    ascii.clear();
-                }
+                flush_ascii(&mut ascii, &mut out)?;
                 out.push(codepoint);
                 continue;
             }
             if let Some(ch) = codepoint.to_char()
                 && ch.is_ascii()
             {
                 ascii.push(ch);
                 continue;
             }
 
-            if !ascii.is_empty() {
-                let part =
-                    host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-                out.extend(part.chars());
-                ascii.clear();
-            }
+            flush_ascii(&mut ascii, &mut out)?;
             out.push(codepoint);
         }
-        if !ascii.is_empty() {
-            let part = host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-            out.extend(part.chars());
-        }
+        flush_ascii(&mut ascii, &mut out)?;
         Ok(out.to_pyobject(vm))

Also applies to: 589-598

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/vm/src/stdlib/time.rs` around lines 571 - 578, In the time-formatting
loop, extract the repeated non-empty `ascii` buffer flush into a local helper
closure that calls `host_time::strftime_ascii`, extends `out`, and clears
`ascii`; replace all three duplicated flush blocks with this closure while
preserving error propagation and existing output behavior.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes