GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — Fix disabled stream identity and conditional annotation operand checks by youknowdot · Pull Request #8960 · RustPython/RustPython Conversation
Contributor
Two existing Python 3.14 paths violate runtime object contracts: disabling standard I/O creates fresh None objects, and conditional-annotation tracking assumes a user-rebindable global is an exact set. Return the context's None singleton for all six disabled stream attributes, and validate the set operand before adding an annotation name. Include an embedding regression that actually runs without the Extracted from #8954 onto main Fresh standalone validation on
The official annotation backport commit AI assistance: prepared, reviewed and tested with Codex at the user's direction. Exact model metadata is unavailable; the commit records
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsReturn the context's canonical None singleton when standard streams are disabled. Check the exact set type before accessing user-rebindable conditional-annotation tracking objects. Both fixes apply to the unchanged Python 3.14 target. Include the no-stdio embedding regression and the unchanged canonical regression from CPython's 3.14 maintenance backport c21e7c45, after the vulnerable 3.14.7 tag. Extracted from the larger 3.15 migration; no marshal or version changes. Assisted-by: Codex:model-version-unavailable
|
There was an error while loading. Please reload this page.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/typing.py dependencies:
dependent tests: (19 tests)
Legend:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| class RegressionTests(unittest.TestCase): | ||
| # gh-154902 | ||
| def test_conditional_annotations_rebound(self): |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
is this test originated from CPython? otherwise do not directly edit Lib/ files
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is copied verbatim from CPython's official 3.14 maintenance backport c21e7c45, including the accompanying import itertools. The test body, input values, and assertions are unchanged. The only difference is placement within RegressionTests: this PR inserts it before the existing tests, while upstream appended it after test_complex_comprehension_inlining.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.