GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-154902: Type-check the SET_ADD operand by deadlovelll · Pull Request #155072 · python/cpython

Conversation

@deadlovelll

@deadlovelll deadlovelll commented Aug 2, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Type-check the SET_ADD operand

This is an alternative version of fix for #154902, but dedicated to 3.15 and 3.14 only, because we cant change bytecode here

  • Issue: Assigning __conditional_annotations__ crashes the interpreter #154902

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deadlovelll
deadlovelll requested review from JelleZijlstra and markshannon as code owners August 2, 2026 09:02
@bedevere-app bedevere-app Bot added the awaiting review label Aug 2, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 2, 2026
Assigning __conditional_annotations__ crashes the interpreter #154902
Closed
@deadlovelll

deadlovelll commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Here I don't think this is a flake, buggy test. The good news is that it isn't because of the fix, but I can figure out what's wrong in a separate issue, if it's really necessary
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Aug 2, 2026

Copy link
Copy Markdown
Member

Yes, probably needs a new issue for the test failure. Not sure how that made it in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deadlovelll
deadlovelll requested review from a team, 1st1, AA-Turner, AlexWaygood, Eclips4, asvetlov, corona10, erlend-aasland, ezio-melotti, freakboy3742, hugovk, iritkatriel, kumaraditya303, mhsmith, pfmoore, pradyunsg, rhettinger, savannahostrowski, sethmlarson, vsajip, webknjaz and willingc as code owners August 5, 2026 10:10
@deadlovelll
pythongh-154902: Type-check the SET_ADD operand
38b448d
@deadlovelll
changed check to PySet_CheckExact, changed exception message
a771775
@deadlovelll
deadlovelll force-pushed the gh-154902-rebind-check-3.14 branch from b057344 to a771775 Compare August 5, 2026 10:17
@deadlovelll

deadlovelll commented Aug 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'm SO sorry for the force! I tried to update the branch for the current 3.14 version, but I did it incorrectly at first =(

I can re-open the pr if i did it dirty
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith
mhsmith removed request for a team, 1st1, AA-Turner, AlexWaygood, Eclips4, asvetlov, corona10, erlend-aasland, ezio-melotti, freakboy3742, hugovk, iritkatriel, kumaraditya303, mhsmith, pfmoore, pradyunsg, rhettinger, savannahostrowski, sethmlarson, vsajip, webknjaz and willingc August 5, 2026 10:40
@JelleZijlstra
JelleZijlstra merged commit c21e7c4 into python:3.14 Aug 5, 2026
71 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 5, 2026
@youknowdot youknowdot mentioned this pull request Oct 4, 2026
Fix disabled stream identity and conditional annotation operand checks RustPython/RustPython#8960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@deadlovelll @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.