GeezerVison

⚙️ Run configuration

• Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
• Review profile: CHILL
• Plan: Advanced
• Run ID: ff283352-d318-41ad-91a4-dca7aeb41a9d

📥 Commits

Reviewing files that changed from the base of the PR and between 5cd074a and b6c253d.

📒 Files selected for processing: 1

• crates/vm/src/stdlib/_functools.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Extended calls now collect positional arguments and keyword names separately and dispatch through vectorcall. PyPartial adds vectorcall handling, including placeholder filling and keyword merging. The dict-key hashing helper is available to other modules in the crate.

Changes: Call Dispatch

Layer / File(s)	Summary
Extended-call argument collection and wiring crates/vm/src/frame.rs	collect_ex_args returns positional values and keyword names separately. It requires keyword keys to be strings and preserves the original key objects. Both extended-call opcodes use this representation.
Vectorcall execution and instrumentation crates/vm/src/frame.rs	execute_call_ex invokes vectorcall with keyword names. Instrumented calls report the first positional argument, or the missing-value sentinel, and handle call and C return or raise events.
PyPartial vectorcall and keyword merging crates/vm/src/builtins/dict.rs, crates/vm/src/stdlib/_functools.rs	PyDict::hash_or_unhashable becomes crate-visible. PyPartial fills placeholders and merges stored and incoming keywords. It uses vectorcall when supported and retains a FuncArgs fallback.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant CALL_FUNCTION_EX
  participant collect_ex_args
  participant execute_call_ex
  participant vectorcall
  participant monitoring
  CALL_FUNCTION_EX->>collect_ex_args: collect positional values and keyword names
  collect_ex_args-->>CALL_FUNCTION_EX: return arguments and names
  CALL_FUNCTION_EX->>execute_call_ex: dispatch collected arguments
  execute_call_ex->>vectorcall: invoke callable with keyword names
  execute_call_ex->>monitoring: report events when instrumented

Loading

Suggested reviewers: youknowone

The change preserves keyword string-subclass identity through extended calls and partial vectorcall, with the earlier non-string keyword panic fixed. No concrete merge-blocking risk is evidenced; hosted CI is still needed.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preserving partial keyword identity through vectorcall.

🧪 Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.