GeezerVison is showing github.com — Fix ctypes subclass bitfields and native type metadata by 1ndahous3 · Pull Request #9395 · RustPython/RustPython
Conversation
1ndahous3
commented
Oct 26, 2026
•
edited by coderabbitai
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to #9390, addressing issues found during its review.
Summary
- Preserve storage-backed views for scalar subclass bitfields, including writes through
.value.
- Use initialized metadata for native argument/result conversion and cast validation, so reassigning
_type_ cannot change the native representation or pointer eligibility.
AI assistance
Written with Codex (GPT-6), reviewed by a human before submission.
Summary by CodeRabbit
- Bug Fixes
- Improved
ctypes handling when scalar and pointer subclasses change their type attributes, including native-call conversion, pointer casting, and bitfield access.
- Preserved whole-byte behavior for boolean bitfields and correct handling of non-scalar subclasses.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-26T12:53:41.186279Z |
2bb1026 |
PR opened |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coderabbitai
Bot
commented
Oct 26, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

No actionable comments were generated in the recent review.
Recent review info
-
Run configuration
-
Commits
-
Reviewing files that changed from the base of the PR and between b811715 and 2bb1026.
Files selected for processing: 3
-
crates/vm/src/stdlib/_ctypes/base.rs
crates/vm/src/stdlib/_ctypes/function.rs
extra_tests/snippets/stdlib_ctypes.py
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
Walkthrough
-
ctypes argument and return handling now uses initialized type metadata instead of the mutable _type_ attribute. Bitfield reads use the extraction path only for scalar-returning fields. New tests cover mutated scalar subclass metadata, pointer casting, and bitfield access.
Changes: ctypes conversion and field access
| Layer / File(s) |
Summary |
Native conversion and pointer checks crates/vm/src/stdlib/_ctypes/function.rs, extra_tests/snippets/stdlib_ctypes.py |
Argument validation, pointer casting, return handling, and py_object result detection use stored type metadata. Tests check native-call conversion and pointer casting after _type_ changes. |
Bitfield subclass access crates/vm/src/stdlib/_ctypes/base.rs, extra_tests/snippets/stdlib_ctypes.py |
Bitfield extraction applies when the field returns a scalar. Tests check access to a MutableInt bitfield. A comment notes that c_bool writes the whole byte for bitfields; setter logic is unchanged. |
Priority: Normal
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Possibly related PRs
- RustPython/RustPython#9390: Changes ctypes scalar metadata, bitfield access, and native conversion; this PR addresses related scalar-subclass cases.
- RustPython/RustPython#9229: Introduces storage-backed ctypes views and initialized scalar metadata used by these changes.
- RustPython/RustPython#9251: Introduces initialized scalar codes and storage-backed scalar field handling extended here.
Suggested reviewers: youknowone
Merge Risk: Minimal · up to 2bb10
-
The reviewed changes have no established merge-blocking issue; they are ready for normal checks.
Pre-merge checks: 4 · 1
-
Failed checks: 1 warning
| Check name |
Status |
Explanation |
Resolution |
| Docstring Coverage |
 |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. |
Write docstrings for the functions missing them to satisfy the coverage threshold. |
Passed checks: 4 passed
-
| Check name |
Status |
Explanation |
| Description Check |
 |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check |
 |
The title clearly and concisely describes the main changes: fixing ctypes subclass bitfields and using native type metadata. |
| Linked Issues check |
 |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check |
 |
Check skipped because no linked issues were found for this pull request. |
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
-
Comment @coderabbitai help to get the list of available commands.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|