GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Report uncomparable reference signatures by youknowdot · Pull Request #9577 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Summary

whats_left can currently compare a CPython introspection exception with a RustPython signature as if the exception were a reference signature. For example, the CI report records select.epoll.register with an AttributeError on the CPython side. That observation cannot establish a signature mismatch.

  • Record whether inspect.signature raised, and list every CPython introspection failure explicitly as an uncomparable signature observation, including its exception. Aliases may appear more than once; the summary counts groups, not unique callables.
  • Compare signatures only when the CPython reference succeeded. Do not label an inherited member missing solely because the CPython reference could not be inspected; genuine missing members and independent doc differences retain their prior handling.
  • Do not list a module as fully implemented when its reference signatures contain unknowns.

This deliberately changes report accounting. Unknowns are visible, not treated as successful parity, and should be included in any future fail-closed CI coverage baseline. It overlaps the reporting work in #9565; a local source-reviewed composition retains both sets of changes.

Validation

  • Independent source review checked all info-record constructors, inherited members, unknown aliases, result classification, and the local Preserve whats_left comparisons in CI #9565 composition.
  • Focused synthetic execution of the extracted comparison confirmed that AttributeError/ValueError reference failures are reported as unknown, a true mismatch remains a mismatch, and an inherited unknown is not mislabeled missing.
  • git diff --check, Ruff formatting/checks, and the normal commit hook passed. Full whats_left execution was not run locally: the coordinated RustPython native execution guard and lock are absent and the offline dependency cache is incomplete. Hosted three-platform CI is pending.

AI assistance

Implementation and source review were assisted by dot. The runtime does not expose its exact model version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@youknowdot
Report uncomparable reference signatures
0c473f7
Keep CPython introspection failures visible as unknown observations rather than comparing exception text as if it were a signature.

Assisted-by: dot:frontier-intelligence
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 3, 2026
Align whats_left module scan ordering #9579
Merged
Guard raw and inspected signature observations in CI #9628
Draft
@youknowdot
Separate module signature errors
ec0aa72
Assisted-by: dot:frontier-intelligence
@youknowone ChatGPT Codex Connector

youknowone commented Nov 5, 2026

Copy link
Copy Markdown
Member

Consolidated into #9628 at c03518e. This PR's head is preserved as an ancestor, and all focused tests are now in the single scripts/tests/test_whatsleft.py file. Closing this duplicate so the remaining whats_left work is reviewed in one PR. The combined 35-test CPython 3.15 suite passes; final-head hosted CI is still pending.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone youknowone closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowdot @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.