GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve whats_left comparisons in CI by youknowdot · Pull Request #9565 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

  • Add --json-output PATH to whats_left.py so the complete structured comparison can be preserved while retaining the existing human-readable --signature output.
  • Include CPython builtin signature inventory and skipped CPython reference imports in the structured result, so a future gate can detect reference-coverage loss. The new human summary rows count inventory groups and import failures, not signature mismatches.
  • Upload the complete JSON and a Python/platform/runner/commit context sidecar from each existing Linux, macOS, and Windows CI job. The GITHUB_SHA in a PR run is a merge commit; establish future baselines from main push runs.
  • Fail the scan if its RustPython subprocess exits unsuccessfully, rather than potentially accepting a JSON-looking last line from a failed process.

This is a data-collection step toward a transparent text-signature regression gate, not a gate and not a claim of signature parity. No mismatches or missing/import failures are filtered out. A later check must detect regressions and coverage loss, and eventually require zero mismatches.

Validation

  • Focused Python AST-extracted checks verified sample JSON output, failure on a nonzero child, reference-import failure recording, and builtin signature inventory. The script also passed an AST syntax parse.
  • git diff --check, the normal commit hook, Ruff formatting and Ruff checks passed. Independent source review checked the structured data path, cross-platform quoting, artifact naming and provenance.
  • Full whats_left scans and RustPython workspace/C API tests were not run locally: the coordinated native-execution guard and lock are absent and the offline cache is incomplete. Hosted three-platform scans and the required workflow zizmor scan are pending; no CI pass is claimed.

AI assistance

Implementation and source review were assisted by dot. The runtime does not expose its exact model version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@youknowdot
Preserve complete whats_left CI comparisons
25def4b
Keep the human-readable signature report while publishing machine-readable results and runner provenance for future regression checks. Fail if the RustPython scan itself fails.

Assisted-by: dot:frontier-intelligence
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot
Record CPython reference coverage
3d992f4
Include skipped reference imports and the builtin signature inventory in comparison results so later checks can detect lost reference coverage.

Assisted-by: dot:frontier-intelligence
This was referenced Nov 3, 2026
Report uncomparable reference signatures #9577
Closed
Align whats_left module scan ordering #9579
Merged
Guard raw and inspected signature observations in CI #9628
Draft
Record reference module discovery #9645
Merged
@youknowone ChatGPT Codex Connector

youknowone commented Nov 5, 2026

Copy link
Copy Markdown
Member

Consolidated into #9628 at c03518e. This PR's head is preserved as an ancestor, and all focused tests are now in the single scripts/tests/test_whatsleft.py file. Closing this duplicate so the remaining whats_left work is reviewed in one PR. The combined 35-test CPython 3.15 suite passes; final-head hosted CI is still pending.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowone youknowone closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowdot @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.