GeezerVison is showing github.com — Record reference module discovery by youknowdot · Pull Request #9645 · RustPython/RustPython
Conversation
youknowdot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- Record the top-level names returned by the existing CPython module scanner, the discovered names deliberately ignored, and names passed to its error callback.
- Report explicit truncation when a name is not an exact string or the bounded manifest cannot retain all observations. Existing comparison fields are retained.
- Keep focused reporting-tool tests together in scripts/tests/test_whatsleft.py. Per review, this PR adds no CI test step.
The manifest covers only names returned by the existing top-level scanner. It does not prove that every installable module was discovered, and it does not by itself distinguish every successful reference import from a failed one. It is coverage evidence for future checks, not an enabled signature gate or a claim of signature parity. The implementation performs no extra module imports or attribute lookups, but recording evidence necessarily adds ordinary allocations and references.
Validation
- Five CPython 3.15 reporting-tool tests pass, including scanner errors, ignored and failed names, evaluation order, bounded output, and a hostile string subclass.
- A CPython 3.15 self-scan reported 292 selected scanner names, 5 deliberately ignored names, no scanner errors and no truncation. All prior JSON fields matched a same-environment main control.
- Review follow-through preserves all five test bodies and 12 assertions byte-for-byte while renaming the module, and removes only this PR’s three-line discovery test CI step. Existing scanner and cron behavior are unchanged.
- Baseline, canonical-file, and wildcard CPython unittest discovery pass. Independent review, Ruff formatting/import checks, YAML parsing, diff checks, and normal repository hooks pass. Local zizmor/actionlint were unavailable, so hosted workflow validation remains pending.
- RustPython was not executed locally. This change adds no CI gate or signature-parity claim.
This change overlaps reporter integration lines in #9565 and #9628 and will require careful composition if those land first.
Assisted-by: dot:frontier-intelligence
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Assisted-by: dot:frontier-intelligence
coderabbitai
Bot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

Caution
Review failed
The pull request is closed.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share
-
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
codspeed
Bot
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Merging this PR will not alter performance
✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1
Comparing youknowdot:fix/whatsleft-discovery-manifest-20261103 (1858913) with main (f9ac441)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
|
|
|
|
|
|
- name: Test whats_left discovery reporting
|
|
|
run: python -I -B -m unittest discover -s scripts/tests -p test_whatsleft_discovery.py -v
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't add this to CI. and test_whatsleft must be a single file rather than series of tests
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Preserve all discovery tests while removing the added CI test step requested in review.
Assisted-by: OpenAI Codex:model version not exposed
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
⚠️ Failed 2026-11-05T14:25:07.700100Z We couldn’t complete this review. Comment @codex review to try again. |
1858913 |
Draft marked ready |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|