GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable pyexpat bytes test by kairosci · Pull Request #9662 · RustPython/RustPython

Enable pyexpat bytes test #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kairosci wants to merge 7 commits into RustPython:main
base: main
Loading
Loading
from kairosci:fix/issue-8083-parse-bytes

Uh oh!

There was an error while loading. Please reload this page.

Open

Enable pyexpat bytes test #9662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03b72eb
fix: support pyexpat byte parsing
kairosci Nov 4, 2026
a240a50
Fix pyexpat review findings
kairosci Nov 4, 2026
01fcea8
Address pyexpat PR review feedback
kairosci Nov 4, 2026
0ffaba1
Fix pyexpat review findings
kairosci Nov 4, 2026
9199fe1
Fix pyexpat CI failures
kairosci Nov 6, 2026
66ec8c6
fix(pyexpat): replay DTD callbacks with source context
kairosci Nov 12, 2026
17aeef3
Merge upstream/main into fix/issue-8083-parse-bytes
kairosci Nov 12, 2026
File filter
Filter by extension

Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Diff view
Diff view

Some comments aren't visible on the classic Files Changed page.

There are no files selected for viewing

1 change: 0 additions & 1 deletion 1 Lib/test/test_minidom.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,6 @@ def handle(self, operation, key, data, src, dst):
self.assertIs(handler.src, entity)
self.assertIs(handler.dst, dst)

@unittest.expectedFailure # TODO: RUSTPYTHON
def testCloneNodeEntity(self):
self.check_clone_node_entity(False)
self.check_clone_node_entity(True)
Expand Down
1 change: 0 additions & 1 deletion 1 Lib/test/test_plistlib.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,6 @@ def test_modified_uid_huge(self):
with self.assertRaises(OverflowError):
plistlib.dumps(huge_uid, fmt=plistlib.FMT_BINARY)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_xml_plist_with_entity_decl(self):
with self.assertRaisesRegex(plistlib.InvalidFileException,
"XML entity declarations are not supported"):
Expand Down
4 changes: 0 additions & 4 deletions 4 Lib/test/test_pyexpat.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ def _verify_parse_output(self, operations):
]
self.assertEqual(operations, expected_operations)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_parse_bytes(self):
out = self.Outputter()
parser = expat.ParserCreate(namespace_separator='!')
Expand All @@ -253,7 +252,6 @@ def test_parse_str(self):
operations = out.out
self._verify_parse_output(operations)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_parse_file(self):
# Try parsing a file
out = self.Outputter()
Expand All @@ -266,7 +264,6 @@ def test_parse_file(self):
operations = out.out
self._verify_parse_output(operations)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_parse_again(self):
parser = expat.ParserCreate()
file = BytesIO(data)
Expand Down Expand Up @@ -879,7 +876,6 @@ def test_trigger_leak(self):
parser.ElementDeclHandler = lambda _1, _2: None
self.assertRaises(TypeError, parser.Parse, data, True)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: RecursionError not raised
@support.skip_if_huge_c_stack(800_000)
@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
Expand Down
2 changes: 0 additions & 2 deletions 2 Lib/test/test_sax.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,6 @@ def resolveEntity(self, publicId, systemId):
source.setSystemId(systemId)
return source

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: 'xmlparser' object has no attribute 'SetParamEntityParsing'
def test_expat_dtdhandler(self):
parser = create_parser()
handler = self.TestDTDHandler()
Expand Down Expand Up @@ -1482,7 +1481,6 @@ def setUp(self):
self.end_of_dtd = False
self.comments = []

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: 'xmlparser' object has no attribute 'SetParamEntityParsing'
def test_handlers(self):
class TestLexicalHandler(LexicalHandler):
def __init__(self, test_harness, *args, **kwargs):
Expand Down
7 changes: 5 additions & 2 deletions 7 crates/host_env/src/socket.rs
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,8 +1064,11 @@ pub fn parse_ancillary_messages(control: &[u8]) -> Vec<AncillaryMessage> {
result
}

#[cfg(test)]
#[cfg(all(unix, not(target_os = "redox")))]
#[cfg(all(test, unix, not(target_os = "redox")))]
#[allow(
clippy::tests_outside_test_module,
Comment thread
kairosci marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

reason = "the platform-gated module is compiled only for tests"
)]
mod ancillary_parse_tests {
use super::{checked_cmsg_len, checked_cmsg_space, parse_ancillary_messages};

Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.