GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — Share exception state and callback controls by youknowdot · Pull Request #9719 · RustPython/RustPython Conversation
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Preserve lazy dictionaries and reduction identity, propagate public formatting errors, honor dynamic state and note protocols, and share borrowed tuple conversion while retaining internal diagnostic behavior. Assisted-by: OpenAI Codex:model version not exposed
Share raw argument installation and keyword validation while retaining original owners across reentrant cleanup. Assisted-by: OpenAI Codex:model version not exposed
2bd4bef to
443306b
Compare
| #[pymethod(name = "add_note")] | ||
| fn add_note_object(&self, note: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
keep this fn name to add_note to avoid to overrride name. give another name to current pub fn add_note
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 244b7bf: the Python wrapper is now add_note with plain #[pymethod], and the typed Rust helper is add_note_str. Updated all Rust callers. Focused VM/stdlib Clippy, formatting, and commit hooks pass.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Rename the typed Rust helper to add_note_str and update its callers so the Python wrapper needs no name override. Assisted-by: OpenAI Codex:model version not exposed
Merging this PR will not alter performance
Comparing Footnotes
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.