GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Align builtin reduction callback controls by youknowdot · Pull Request #9718 · RustPython/RustPython Conversation
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a8ae033 to
215c7f0
Compare
There was an error while loading. Please reload this page.
Merging this PR will not alter performance
Comparing Footnotes
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| pub(super) struct SumArgs { | ||
| #[pyarg(positional)] | ||
| iterable: ArgIterable, | ||
| iterable: PyObjectRef, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
check this change is necessary after #9563
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| } | ||
|
|
||
| fn all_or_any( | ||
| iterable: &PyObjectRef, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| iterable: &PyObjectRef, | |
| iterable: &PyObject, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
215c7f0 to
44ebf49
Compare
Preserve callback and internal owner order, retain raw caller arguments, and reuse keyword matching and suggestion machinery without changing existing parser consumers. Assisted-by: OpenAI Codex:model version not exposed
Validate the iterator before rejecting the start type, retain raw arguments, and release generic accumulator operands in CPython order without changing numeric fast paths. Assisted-by: OpenAI Codex:model version not exposed
Release the iterator before the original start on generic success, preserving callback lifetime order while making the required retention visible to Clippy. Assisted-by: OpenAI Codex:model version not exposed
Validate iterator acquisition before traversal, cache the next slot while preserving dynamic method dispatch, and retain existing item and terminal cleanup boundaries. Assisted-by: OpenAI Codex:model version not exposed
All builtin reduction entry points now retain raw objects, leaving this adapter import unused. Assisted-by: OpenAI Codex:model version not exposed
Preserve borrowed keyword ownership and existing slot validation after the getargs migration. Assisted-by: OpenAI Codex:model version not exposed
Preserve callback ownership, release ordering, and retained argument owners. Assisted-by: Codex:model-version-unavailable
Use the shared get_iter entry point while the wrappers retain the original iterable through all callbacks. This changes helper ownership coupling, not reference-count traffic. Assisted-by: OpenAI Codex:GPT-6
44ebf49 to
29ef984
Compare
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.